feat(storefront): strf-9921 Hide logging for successful internal API calls in Stencil CLI: #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calls in Stencil CLI: - verbose logging was moved to non-default option;
bc-max
force-pushed
the
STRF-9921-Hide-logging-for-successful-internal-API-calls-in-Stencil-CLI
branch
from
ab411c1
to
6935b9e
Compare
…calls in Stencil CLI: - tests fixed;
…calls in Stencil CLI: - tests fixed;
jairo-bc
reviewed
Nov 23, 2022
| @@ -87,7 +87,7 @@ function checkNodeVersion() { | |||
| function applyCommonOptions(program) { | |||
| program | |||
| .option('-h, --host [hostname]', 'specify the api host') | |||
| .option('-nov, --no-verbose', 'supress verbose info logging', false) | |||
| .option('-vb, --verbose', 'enable verbose info logging', false) | |||
There was a problem hiding this comment.
Is it considered as a breaking change and should be documented? As we are following semver, we might want to add the note to the description (or title, we need to check in semantic release docs), so the tool automatically bumps the number to 6.x.x
cc @bookernath
There was a problem hiding this comment.
Yeah, I think we need to update our docs. Thus I made a remark in PR description. Once the PR approved, I'll create respective ticket for documentation team.
jairo-bc
approved these changes
Dec 8, 2022
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
At the moment we have
verboselogging by default. However, Stencil-cli produces too many logs which seems to be too noisy. This PR makesnon-verboseoption as a default one.!!!! This PR requires documentation update
Tickets / Documentation
Screenshots (if appropriate)
cc @bigcommerce/storefront-team