Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycles JS throws invalid circular dependency error #1132

Open
mattcoy-arcticleaf opened this issue Sep 11, 2023 · 0 comments
Open

Cycles JS throws invalid circular dependency error #1132

mattcoy-arcticleaf opened this issue Sep 11, 2023 · 0 comments

Comments

@mattcoy-arcticleaf
Copy link
Contributor

Expected behavior

Because you can include a component inside itself, and Cornerstone does this in a number of places, you should also be able to have circular component dependencies.
https:/bigcommerce/stencil-cli/blob/master/lib/Cycles.js#L41

See usage in Cornerstone:

Actual behavior

If you include a component inside another component, and that component includes the first component, Cycles JS throws an error saying Error: Circular dependency in template detected.

Steps to reproduce behavior

Include component X inside component Y, then include component Y inside component X.

Environment

Stencil-cli version stencil --version: 7.0.1

Node version node -v: v18.15.0

NPM version npm -v: 9.6.4

OS: Mac 13.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant