fix(storefront): strf-10130 Fix 404s on pagination in brands/categories #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanarldt
force-pushed
the
STRF-10130
branch
2 times, most recently
from
e987b15
to
a24d256
Compare
jordanarldt
force-pushed
the
STRF-10130
branch
from
a24d256
to
a1470bf
Compare
jordanarldt
changed the title
Merged
jmwiese
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add some logic to exclude the
pagequery parameter from the initial request to BCApp from Stencil CLI.This will allow us to avoid receiving a 404 on the first request to BCApp, which will allow Stencil to gather the front-matter data, parse it, and then send another BCApp request with the appropriate information regarding the category/brands pages.
Tickets / Documentation
Screenshots (if appropriate)
Original Behavior:
After fix:
cc @bigcommerce/storefront-team