Refactor getStoreChannels function #1187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AndrewBarber! Thanks for contributing to the project! |
|
Hey @AndrewBarber , Thank you for this PR and the suggestions! I am including your changes into a PR I just made with updates to this same area: Just letting you know to save you time to updating your PR as it should no longer be needed. |
|
Closing as we incorporated these changes into: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Within
getStoreChannelswe fetch store channels, then filter them to access only storefront type channels.This can be made within the request, reducing the complexity of the codebase, as well as putting the processing on the server side.
Tickets / Documentation
N/A
Screenshots (if appropriate)
N/A
cc @bigcommerce/storefront-team