feat: strf-9245 Warn user if shopper default language file is missing or has missing keys #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jairo-bc
requested review from
zvuki,
jmwiese,
bc-jz,
bookernath and
pachanady
jmwiese
reviewed
Dec 2, 2021
lib/stencil-start.js
Outdated
| this._logger.log( | ||
| `${ | ||
| 'Warning'.yellow | ||
| }: lang folder is missing default shopper language: ${defaultShopperLanguage}`, |
There was a problem hiding this comment.
🍹 I would maybe reword this to be something like "missing language file for default shopper language: ${defaultShopperLanguage}". I think that reads more naturally to me.
jmwiese
reviewed
Dec 2, 2021
lib/lang-helper.js
Outdated
| this._logger.log( | ||
| `${ | ||
| 'Warning'.yellow | ||
| }: file: ${defaultLangFilePath} doesn't have ${langKey}, which is presented in ${filePath}`, |
There was a problem hiding this comment.
🍹 which is presented in -> which is present in
jmwiese
approved these changes
Dec 2, 2021
|
Nice work! |
bookernath
approved these changes
Dec 2, 2021
… or has missing keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As a Stencil CLI user,
When I run
stencil startfor a particular store,I will receive a warning if the store's default shopper language does not have a language file within the theme.
Tickets / Documentation
Screenshots (if appropriate)
cc @bigcommerce/storefront-team