Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storefront): BCTHEME-1000 handle correctly css extension in stencil #845

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

bc-alexsaiannyi
Copy link
Contributor

@bc-alexsaiannyi bc-alexsaiannyi commented Jan 20, 2022

What?

While working on Prelude POC we would like to change new Stencil Theme structure:

  • keep SCSS directory under assets but generate css files under dist/css dir,
  • use regular css extension for it.
  • use css_compiler flag

If we use mentioned structure, stencil-cli gives us an error in local development. For this reason we would like to add possibility for stencil-cli to work with regular css as well as aseets/scss directory. On theme side, we will use css_compiler flag from config.json that can be switched between scss and css. On Stencil side we will provide this extension to CSS Compiler Handler which then will assemble CSS accordingly.

Tickets / Documentation

Screenshots (if appropriate)

new_assets_dir

cornerstone_test_after_720p.mov
new_theme_test_after_720p.mov

Here our Theme structure at the moment

cc @bigcommerce/storefront-team

@jairo-bc
Copy link
Contributor

@bc-alexsaiannyi Could you please fix conflict and provide some screenshots as a proof, that is working on cornerstone as well

Copy link
Contributor

@jairo-bc jairo-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Take a look at the previous comment

@bc-alexsaiannyi bc-alexsaiannyi force-pushed the bctheme-1000 branch 2 times, most recently from 8eef7b2 to 64aa942 Compare February 2, 2022 11:48
@jairo-bc
Copy link
Contributor

jairo-bc commented Feb 3, 2022

I would also recommend to check other commands if they are affected it particular: stencil download and stencil push
@bc-alexsaiannyi

@jairo-bc jairo-bc merged commit 80230c3 into bigcommerce:master Feb 8, 2022
@jairo-bc jairo-bc mentioned this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants