Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix on partial message retrieval #2788

Merged
merged 2 commits into from
May 11, 2023

Conversation

digant73
Copy link
Contributor

@digant73 digant73 commented May 7, 2023

BUG FIXES:

  • wrong retrieval of partial message from L1 cache: this scenario typically happens when the TFT receives a burst of messages (e.g. the output for "M420 V1 T1"). The first fully received message (terminated by "\n") is enough to trigger the L1 cache as available (infoHost.rx_ok[portIndex] set to "true") for reading. As consequence, the partial retrieved message is not properly processed by the TFT (e.g. a partial echo message is displayed as an error popup, a truncated message breaks the expected handling etc...).
    E.g. the wrong number of rows sometimes displayed on Mesh Edit menu (see attached picture) (e.g. a 6x7 grid instead of the expected 7x7) was caused by this bug.
    Probably, the bug occurs more often on not fast TFTs and/or too fast/burst communication speed with main boards.
    The bug fix could fix some unusual bugs reported by users.

PR STATE: ready for merge

IMG_20230506_185107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants