chore: rename rome_js_unicode_table to biome_js_unicode_table #88 (…

…#205)
biomejs · Sep 8, 2023 · 579d515 · 579d515
1 parent 92be3f8
commit 579d515
Show file tree

Hide file tree

Showing 18 changed files with 79 additions and 75 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -1,5 +1,5 @@
 * text=auto eol=lf
-crates/rome_js_unicode_table/src/tables.rs linguist-generated=true text=auto eol=lf
+crates/biome_js_unicode_table/src/tables.rs linguist-generated=true text=auto eol=lf
 **/generated/* linguist-generated=true text=auto eol=lf
 crates/rome_js_analyze/src/analyzers.rs linguist-generated=true text=auto eol=lf
 crates/rome_js_analyze/src/assists.rs linguist-generated=true text=auto eol=lf

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -32,6 +32,7 @@ biome_css_factory = { path = "./crates/biome_css_factory" }
 biome_css_parser = { path = "./crates/biome_css_parser" }
 biome_css_syntax = { path = "./crates/biome_css_syntax" }
 biome_flags = { path = "./crates/biome_flags" }
+biome_js_unicode_table = { version = "0.0.1", path = "./crates/biome_js_unicode_table" }
 biome_lsp = { path = "./crates/biome_lsp" }
 biome_markup = { version = "0.0.1", path = "./crates/biome_markup" }
 biome_test_utils = { path = "./crates/biome_test_utils" }
@@ -53,7 +54,6 @@ rome_js_formatter = { path = "./crates/rome_js_formatter" }
 rome_js_parser = { path = "./crates/rome_js_parser" }
 rome_js_semantic = { path = "./crates/rome_js_semantic" }
 rome_js_syntax = { version = "0.2.0", path = "./crates/rome_js_syntax" }
-rome_js_unicode_table = { version = "0.0.1", path = "./crates/rome_js_unicode_table" }
 rome_json_analyze = { path = "./crates/rome_json_analyze" }
 rome_json_factory = { version = "0.2.0", path = "./crates/rome_json_factory" }
 rome_json_formatter = { path = "./crates/rome_json_formatter" }

diff --git a/crates/biome_css_parser/Cargo.toml b/crates/biome_css_parser/Cargo.toml
@@ -11,14 +11,14 @@ repository.workspace = true
 version = "0.1.0"
 
 [dependencies]
-biome_css_factory = { workspace = true }
-biome_css_syntax = { workspace = true }
-rome_console  = { workspace = true }
-rome_diagnostics = { workspace = true }
-rome_js_unicode_table = { workspace = true }
-rome_parser = { workspace = true }
-rome_rowan = { workspace = true }
-tracing = { workspace = true }
+biome_css_factory  = { workspace = true }
+biome_css_syntax  = { workspace = true }
+biome_js_unicode_table = { workspace = true }
+rome_console  = { workspace = true }
+rome_diagnostics  = { workspace = true }
+rome_parser  = { workspace = true }
+rome_rowan  = { workspace = true }
+tracing  = { workspace = true }
 
 [dev-dependencies]
 insta = { workspace = true }

diff --git a/crates/biome_css_parser/src/lexer/mod.rs b/crates/biome_css_parser/src/lexer/mod.rs
@@ -4,7 +4,7 @@ mod tests;
 
 use crate::CssParserOptions;
 use biome_css_syntax::{CssSyntaxKind, CssSyntaxKind::*, TextLen, TextRange, TextSize, T};
-use rome_js_unicode_table::{is_id_continue, is_id_start, lookup_byte, Dispatch::*};
+use biome_js_unicode_table::{is_id_continue, is_id_start, lookup_byte, Dispatch::*};
 use rome_parser::diagnostic::ParseDiagnostic;
 use std::char::REPLACEMENT_CHARACTER;
 use std::iter::FusedIterator;

diff --git a/crates/rome_js_unicode_table/Cargo.toml → crates/biome_js_unicode_table/Cargo.toml b/crates/rome_js_unicode_table/Cargo.toml → crates/biome_js_unicode_table/Cargo.toml
@@ -4,7 +4,7 @@ description = "Unicode table for JavaScript IDs"
 documentation = "https://docs.rs/rome_js_parser"
 edition.workspace = true
 license.workspace = true
-name = "rome_js_unicode_table"
+name = "biome_js_unicode_table"
 repository.workspace = true
 version = "0.0.1"
 

diff --git a/crates/rome_js_unicode_table/src/bytes.rs → crates/biome_js_unicode_table/src/bytes.rs b/crates/rome_js_unicode_table/src/bytes.rs → crates/biome_js_unicode_table/src/bytes.rs
diff --git a/crates/rome_js_unicode_table/src/lib.rs → crates/biome_js_unicode_table/src/lib.rs b/crates/rome_js_unicode_table/src/lib.rs → crates/biome_js_unicode_table/src/lib.rs
@@ -22,7 +22,7 @@ pub fn is_id_continue(c: char) -> bool {
 /// Currently, it doesn't check escaped unicode chars.
 ///
 /// ```
-/// use rome_js_unicode_table::is_js_ident;
+/// use biome_js_unicode_table::is_js_ident;
 ///
 /// assert!(is_js_ident("id0"));
 /// assert!(is_js_ident("$id$"));

diff --git a/crates/rome_js_unicode_table/src/tables.rs → crates/biome_js_unicode_table/src/tables.rs b/crates/rome_js_unicode_table/src/tables.rs → crates/biome_js_unicode_table/src/tables.rs
diff --git a/crates/rome_cli/tests/commands/format.rs b/crates/rome_cli/tests/commands/format.rs
@@ -69,10 +69,14 @@ action => {};
 (action = 1) => {};
 "#;
 
+// Without this, Test (windows-latest) fails with: `warning: constant `DEFAULT_CONFIGURATION_BEFORE` is never used`
+#[allow(dead_code)]
 const DEFAULT_CONFIGURATION_BEFORE: &str = r#"function f() {
  return { a, b }
  }"#;
 
+// Without this, Test (windows-latest) fails with: `warning: constant `DEFAULT_CONFIGURATION_AFTER` is never used`
+#[allow(dead_code)]
 const DEFAULT_CONFIGURATION_AFTER: &str = "function f() {
  return { a, b };
 }

diff --git a/crates/rome_js_analyze/Cargo.toml b/crates/rome_js_analyze/Cargo.toml
@@ -7,28 +7,28 @@ repository.workspace = true
 version = "0.2.0"
 
 [dependencies]
-biome_analyze = { workspace = true }
-biome_aria = { workspace = true }
-bpaf.workspace = true
-lazy_static  = { workspace = true }
-natord  = "1.0.9"
-roaring = "0.10.1"
-rome_console = { workspace = true }
-rome_control_flow = { workspace = true }
-rome_deserialize = { workspace = true }
-rome_diagnostics = { workspace = true }
-rome_js_factory = { workspace = true }
-rome_js_semantic = { workspace = true }
-rome_js_syntax  = { workspace = true }
-rome_js_unicode_table = { workspace = true }
-rome_json_factory = { workspace = true }
-rome_json_syntax = { workspace = true }
-rome_rowan = { workspace = true }
-rustc-hash = { workspace = true }
-schemars = { workspace = true, optional = true }
-serde = { workspace = true, features = ["derive"] }
-serde_json = { workspace = true }
-smallvec = { workspace = true }
+biome_analyze  = { workspace = true }
+biome_aria  = { workspace = true }
+biome_js_unicode_table = { workspace = true }
+bpaf.workspace = true
+lazy_static = { workspace = true }
+natord  = "1.0.9"
+roaring  = "0.10.1"
+rome_console  = { workspace = true }
+rome_control_flow = { workspace = true }
+rome_deserialize  = { workspace = true }
+rome_diagnostics = { workspace = true }
+rome_js_factory  = { workspace = true }
+rome_js_semantic = { workspace = true }
+rome_js_syntax  = { workspace = true }
+rome_json_factory  = { workspace = true }
+rome_json_syntax  = { workspace = true }
+rome_rowan  = { workspace = true }
+rustc-hash  = { workspace = true }
+schemars  = { workspace = true, optional = true }
+serde  = { workspace = true, features = ["derive"] }
+serde_json  = { workspace = true }
+smallvec  = { workspace = true }
 
 [dev-dependencies]
 biome_test_utils = { workspace = true }

diff --git a/crates/rome_js_analyze/src/analyzers/complexity/use_literal_keys.rs b/crates/rome_js_analyze/src/analyzers/complexity/use_literal_keys.rs
@@ -2,6 +2,7 @@ use crate::JsRuleAction;
 use biome_analyze::{
  context::RuleContext, declare_rule, ActionCategory, Ast, Rule, RuleDiagnostic,
 };
+use biome_js_unicode_table::is_js_ident;
 use rome_console::markup;
 use rome_diagnostics::Applicability;
 use rome_js_factory::make::{
@@ -11,7 +12,6 @@ use rome_js_syntax::{
  AnyJsComputedMember, AnyJsExpression, AnyJsLiteralExpression, AnyJsName, JsComputedMemberName,
  JsLiteralMemberName, JsSyntaxKind, T,
 };
-use rome_js_unicode_table::is_js_ident;
 use rome_rowan::{declare_node_union, AstNode, BatchMutationExt, TextRange};
 
 declare_rule! {

diff --git a/crates/rome_js_analyze/src/semantic_analyzers/nursery/use_naming_convention.rs b/crates/rome_js_analyze/src/semantic_analyzers/nursery/use_naming_convention.rs
@@ -8,6 +8,7 @@ use crate::{
  JsRuleAction,
 };
 use biome_analyze::{context::RuleContext, declare_rule, ActionCategory, Rule, RuleDiagnostic};
+use biome_js_unicode_table::is_js_ident;
 use bpaf::Bpaf;
 use rome_console::markup;
 use rome_deserialize::{
@@ -22,7 +23,6 @@ use rome_js_syntax::{
  JsLiteralMemberName, JsPrivateClassMemberName, JsSyntaxKind, JsSyntaxToken,
  JsVariableDeclarator, JsVariableKind, TsEnumMember, TsIdentifierBinding, TsTypeParameterName,
 };
-use rome_js_unicode_table::is_js_ident;
 use rome_json_syntax::JsonLanguage;
 use rome_rowan::{
  declare_node_union, AstNode, AstNodeList, BatchMutationExt, SyntaxNode, SyntaxResult, TokenText,

diff --git a/crates/rome_js_parser/Cargo.toml b/crates/rome_js_parser/Cargo.toml
@@ -11,22 +11,22 @@ repository.workspace = true
 version = "0.1.0"
 
 [dependencies]
-bitflags  = { workspace = true }
-cfg-if  = "1.0.0"
-drop_bomb = "0.1.5"
-indexmap = { workspace = true }
-rome_console = { workspace = true }
-rome_diagnostics = { workspace = true }
-rome_js_factory = { workspace = true }
-rome_js_syntax = { workspace = true }
-rome_js_unicode_table = { workspace = true }
-rome_parser = { workspace = true }
-rome_rowan = { workspace = true }
-schemars = { workspace = true, optional = true }
-serde = { workspace = true, features = ["derive"] }
-serde_json = { workspace = true }
-smallvec = { workspace = true }
-tracing = { workspace = true }
+biome_js_unicode_table = { workspace = true }
+bitflags = { workspace = true }
+cfg-if  = "1.0.0"
+drop_bomb = "0.1.5"
+indexmap  = { workspace = true }
+rome_console  = { workspace = true }
+rome_diagnostics = { workspace = true }
+rome_js_factory = { workspace = true }
+rome_js_syntax  = { workspace = true }
+rome_parser  = { workspace = true }
+rome_rowan  = { workspace = true }
+schemars  = { workspace = true, optional = true }
+serde  = { workspace = true, features = ["derive"] }
+serde_json  = { workspace = true }
+smallvec  = { workspace = true }
+tracing  = { workspace = true }
 
 [dev-dependencies]
 expect-test = "1.2.2"

diff --git a/crates/rome_js_parser/src/lexer/mod.rs b/crates/rome_js_parser/src/lexer/mod.rs
@@ -27,13 +27,13 @@ use bitflags::bitflags;
 #[cfg(feature = "highlight")]
 pub use highlight::*;
 
-pub(crate) use buffered_lexer::BufferedLexer;
-use rome_js_syntax::JsSyntaxKind::*;
-pub use rome_js_syntax::*;
-use rome_js_unicode_table::{
+use biome_js_unicode_table::{
  is_id_continue, is_id_start, lookup_byte,
  Dispatch::{self, *},
 };
+pub(crate) use buffered_lexer::BufferedLexer;
+use rome_js_syntax::JsSyntaxKind::*;
+pub use rome_js_syntax::*;
 use rome_parser::diagnostic::ParseDiagnostic;
 
 use self::errors::invalid_digits_after_unicode_escape_sequence;

diff --git a/crates/rome_json_parser/Cargo.toml b/crates/rome_json_parser/Cargo.toml
@@ -11,14 +11,14 @@ repository.workspace = true
 version = "0.1.0"
 
 [dependencies]
-rome_console  = { workspace = true }
-rome_diagnostics = { workspace = true }
-rome_js_unicode_table = { workspace = true }
-rome_json_factory = { workspace = true }
-rome_json_syntax = { workspace = true }
-rome_parser = { workspace = true }
-rome_rowan = { workspace = true }
-tracing = { workspace = true }
+biome_js_unicode_table = { workspace = true }
+rome_console  = { workspace = true }
+rome_diagnostics  = { workspace = true }
+rome_json_factory  = { workspace = true }
+rome_json_syntax  = { workspace = true }
+rome_parser  = { workspace = true }
+rome_rowan  = { workspace = true }
+tracing  = { workspace = true }
 
 [dev-dependencies]
 insta = { workspace = true }

diff --git a/crates/rome_json_parser/src/lexer/mod.rs b/crates/rome_json_parser/src/lexer/mod.rs
@@ -3,7 +3,7 @@
 #[rustfmt::skip]
 mod tests;
 
-use rome_js_unicode_table::{is_id_continue, is_id_start, lookup_byte, Dispatch::*};
+use biome_js_unicode_table::{is_id_continue, is_id_start, lookup_byte, Dispatch::*};
 use rome_json_syntax::{JsonSyntaxKind, JsonSyntaxKind::*, TextLen, TextRange, TextSize, T};
 use rome_parser::diagnostic::ParseDiagnostic;
 use std::iter::FusedIterator;

diff --git a/xtask/codegen/src/unicode.rs b/xtask/codegen/src/unicode.rs
@@ -5,7 +5,7 @@ use quote::quote;
 
 mod paths {
  pub const DERIVED_CORE_PROPERTIES: &str = "target/DerivedCoreProperties.txt";
- pub const TABLES: &str = "crates/rome_js_unicode_table/src/tables.rs";
+ pub const TABLES: &str = "crates/biome_js_unicode_table/src/tables.rs";
 }
 
 pub fn generate_tables() -> Result<()> {