-
-
Notifications
You must be signed in to change notification settings - Fork 465
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(biome_css_analyze): keyframe-block-no-duplicate-selectors (#2534)
Co-authored-by: ty <[email protected]>
- Loading branch information
1 parent
ff73013
commit 5df8781
Showing
11 changed files
with
300 additions
and
18 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82 changes: 82 additions & 0 deletions
82
crates/biome_css_analyze/src/lint/nursery/no_duplicate_selectors_keyframe_block.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,82 @@ | ||
use std::collections::HashSet; | ||
|
||
use biome_analyze::{context::RuleContext, declare_rule, Ast, Rule, RuleDiagnostic, RuleSource}; | ||
use biome_console::markup; | ||
use biome_css_syntax::{AnyCssKeyframesItem, AnyCssKeyframesSelector, CssKeyframesBlock}; | ||
use biome_rowan::AstNode; | ||
|
||
declare_rule! { | ||
/// Disallow duplicate selectors within keyframe blocks. | ||
/// | ||
/// ## Examples | ||
/// | ||
/// ### Invalid | ||
/// | ||
/// ```css,expect_diagnostic | ||
/// @keyframes foo { from {} from {} } | ||
/// ``` | ||
/// | ||
/// ```css,expect_diagnostic | ||
/// @keyframes foo { from {} FROM {} } | ||
/// ``` | ||
/// | ||
/// ```css,expect_diagnostic | ||
/// @keyframes foo { 0% {} 0% {} } | ||
/// ``` | ||
/// | ||
/// ### Valid | ||
/// | ||
/// ```css | ||
/// @keyframes foo { 0% {} 100% {} } | ||
/// ``` | ||
/// | ||
/// ```css | ||
/// @keyframes foo { from {} to {} } | ||
/// ``` | ||
/// | ||
pub NoDuplicateSelectorsKeyframeBlock { | ||
version: "next", | ||
name: "noDuplicateSelectorsKeyframeBlock", | ||
recommended: true, | ||
sources:&[RuleSource::Stylelint("keyframe-block-no-duplicate-selectors")], | ||
} | ||
} | ||
|
||
impl Rule for NoDuplicateSelectorsKeyframeBlock { | ||
type Query = Ast<CssKeyframesBlock>; | ||
type State = AnyCssKeyframesSelector; | ||
type Signals = Option<Self::State>; | ||
type Options = (); | ||
|
||
fn run(ctx: &RuleContext<Self>) -> Option<Self::State> { | ||
let node = ctx.query(); | ||
let mut selector_list = HashSet::new(); | ||
for keyframe_item in node.items() { | ||
match keyframe_item { | ||
AnyCssKeyframesItem::CssKeyframesItem(item) => { | ||
let keyframe_selector = item.selectors().into_iter().next()?.ok()?; | ||
if !selector_list.insert(keyframe_selector.text().to_lowercase()) { | ||
return Some(keyframe_selector); | ||
} | ||
} | ||
_ => return None, | ||
} | ||
} | ||
None | ||
} | ||
|
||
fn diagnostic(_: &RuleContext<Self>, node: &Self::State) -> Option<RuleDiagnostic> { | ||
Some( | ||
RuleDiagnostic::new( | ||
rule_category!(), | ||
node.range(), | ||
markup! { | ||
"Unexpected duplicate selector: "<Emphasis>{node.text()}</Emphasis> | ||
}, | ||
) | ||
.note(markup! { | ||
"Consider using a different percentage value or keyword to avoid duplication" | ||
}), | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
crates/biome_css_analyze/tests/specs/nursery/noDuplicateSelectorsKeyframeBlock/invalid.css
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
@keyframes foo { from {} from {}} | ||
|
||
@keyframes foo { from {} FROM {}} | ||
|
||
@keyframes foo { 0% {} 0% {}} | ||
|
||
@keyframes foo { from {} to {} to {} } | ||
|
||
@keyframes foo { 0% {} 0% {} 100% {} } | ||
|
||
@-webkit-keyframes foo { 0% {} 0% {} 100% {} } | ||
|
||
@-moz-keyframes foo { 0% {} 0% {} 100% {} } |
Oops, something went wrong.