feat(biome_css_analyzer): initilize css linter infra (#2111)

Cargo.toml

@@ -99,6 +99,7 @@ biome_aria = { version = "0.5.7", path = "./crates/biome_aria"
 biome_aria_metadata = { version = "0.5.7", path = "./crates/biome_aria_metadata" }
 biome_console = { version = "0.5.7", path = "./crates/biome_console" }
 biome_control_flow = { version = "0.5.7", path = "./crates/biome_control_flow" }
+biome_css_analyze = { version = "0.5.7", path = "./crates/biome_css_analyze" }
 biome_css_factory = { version = "0.5.7", path = "./crates/biome_css_factory" }
 biome_css_formatter = { version = "0.5.7", path = "./crates/biome_css_formatter" }
 biome_css_parser = { version = "0.5.7", path = "./crates/biome_css_parser" }

crates/biome_css_analyze/src/analyzers/nursery.rs

@@ -2,13 +2,13 @@
 
 use biome_analyze::declare_group;
 
-pub mod noop;
+pub mod no_color_invalid_hex;
 
 declare_group! {
  pub Nursery {
  name : "nursery" ,
  rules : [
- self :: noop :: Noop ,
+ self :: no_color_invalid_hex :: NoColorInvalidHex ,
  ]
  }
 }

crates/biome_css_analyze/src/analyzers/nursery/no_color_invalid_hex.rs

@@ -0,0 +1,72 @@
+use biome_analyze::{context::RuleContext, declare_rule, Ast, Rule, RuleDiagnostic};
+use biome_console::markup;
+use biome_css_syntax::CssDeclarationOrRuleBlock;
+use biome_rowan::AstNode;
+
+declare_rule! {
+ /// Succinct description of the rule.
+ ///
+ /// Put context and details about the rule.
+ /// As a starting point, you can take the description of the corresponding _ESLint_ rule (if any).
+ ///
+ /// Try to stay consistent with the descriptions of implemented rules.
+ ///
+ /// Add a link to the corresponding stylelint rule (if any):
+ ///
+ /// ## Examples
+ ///
+ /// ### Invalid
+ ///
+ /// ```css,expect_diagnostic
+ /// p {}
+ /// ```
+ ///
+ /// ### Valid
+ ///
+ /// ```css
+ /// p {
+ /// color: red;
+ /// }
+ /// ```
+ ///
+ pub NoColorInvalidHex {
+ version: "next",
+ name: "noColorInvalidHex",
+ recommended: false,
+ }
+}
+
+impl Rule for NoColorInvalidHex {
+ type Query = Ast<CssDeclarationOrRuleBlock>;
+ type State = CssDeclarationOrRuleBlock;
+ type Signals = Option<Self::State>;
+ type Options = ();
+
+ fn run(ctx: &RuleContext<Self>) -> Option<Self::State> {
+ let node = ctx.query();
+ if node.items().into_iter().next().is_none() {
+ return Some(node.clone());
+ }
+ None
+ }
+
+ fn diagnostic(_: &RuleContext<Self>, node: &Self::State) -> Option<RuleDiagnostic> {
+ //
+ // Read our guidelines to write great diagnostics:
+ // https://docs.rs/biome_analyze/latest/biome_analyze/#what-a-rule-should-say-to-the-user
+ //
+ let span = node.range();
+ Some(
+ RuleDiagnostic::new(
+ rule_category!(),
+ span,
+ markup! {
+ "Unexpected empty block is not allowed"
+ },
+ )
+ .note(markup! {
+ "This note will give you more information."
+ }),
+ )
+ }
+}

crates/biome_css_analyze/src/lib.rs

@@ -1,4 +1,5 @@
 mod analyzers;
+pub mod options;
 mod registry;
 
 pub use crate::registry::visit_registry;

crates/biome_css_analyze/src/options.rs

@@ -0,0 +1,6 @@
+//! Generated file, do not edit by hand, see `xtask/codegen`
+
+use crate::analyzers;
+
+pub type NoColorInvalidHex =
+ <analyzers::nursery::no_color_invalid_hex::NoColorInvalidHex as biome_analyze::Rule>::Options;

crates/biome_css_analyze/tests/specs/nursery/noColorInvalidHex/invalid.css

@@ -0,0 +1,4 @@
+p { 
+ color: red;
+ text-align: center;
+}

crates/biome_css_analyze/tests/specs/nursery/noop/invalid.css.snap → crates/biome_css_analyze/tests/specs/nursery/noColorInvalidHex/invalid.css.snap

@@ -4,7 +4,8 @@ expression: invalid.css
 ---
 # Input
 ```css
-
+p { 
+ color: red;
+ text-align: center;
+}
 ```
-
-

crates/biome_css_analyze/tests/specs/nursery/noColorInvalidHex/valid.css

@@ -0,0 +1,5 @@
+/* should not generate diagnostics */
+p { 
+ color: red;
+ text-align: center;
+}

crates/biome_css_analyze/tests/specs/nursery/noop/valid.css.snap → crates/biome_css_analyze/tests/specs/nursery/noColorInvalidHex/valid.css.snap

@@ -4,7 +4,9 @@ expression: valid.css
 ---
 # Input
 ```css
-
+/* should not generate diagnostics */
+p { 
+ color: red;
+ text-align: center;
+}
 ```
-
-

crates/biome_diagnostics_categories/src/categories.rs

@@ -106,11 +106,13 @@ define_categories! {
  "lint/correctness/useIsNan": "https://biomejs.dev/linter/rules/use-is-nan",
  "lint/correctness/useValidForDirection": "https://biomejs.dev/linter/rules/use-valid-for-direction",
  "lint/correctness/useYield": "https://biomejs.dev/linter/rules/use-yield",
+ "lint/nursery/colorNoInvalidHex": "https://biomejs.dev/linter/rules/color-no-invalid-hex",
  "lint/nursery/noApproximativeNumericConstant": "https://biomejs.dev/linter/rules/no-approximative-numeric-constant",
  "lint/nursery/noBarrelFile": "https://biomejs.dev/linter/rules/no-barrel-file",
+ "lint/nursery/noColorInvalidHex": "https://biomejs.dev/linter/rules/no-color-invalid-hex",
  "lint/nursery/noConsole": "https://biomejs.dev/linter/rules/no-console",
- "lint/nursery/noDuplicateElseIf": "https://biomejs.dev/linter/rules/no-duplicate-else-if",
  "lint/nursery/noDoneCallback": "https://biomejs.dev/linter/rules/no-done-callback",
+ "lint/nursery/noDuplicateElseIf": "https://biomejs.dev/linter/rules/no-duplicate-else-if",
  "lint/nursery/noDuplicateJsonKeys": "https://biomejs.dev/linter/rules/no-duplicate-json-keys",
  "lint/nursery/noDuplicateTestHooks": "https://biomejs.dev/linter/rules/no-duplicate-test-hooks",
  "lint/nursery/noExcessiveNestedTestSuites": "https://biomejs.dev/linter/rules/no-excessive-nested-test-suites",

crates/biome_service/Cargo.toml

@@ -16,6 +16,7 @@ version = "0.0.0"
 [dependencies]
 biome_analyze = { workspace = true, features = ["serde"] }
 biome_console = { workspace = true }
+biome_css_analyze = { workspace = true }
 biome_css_formatter = { workspace = true }
 biome_css_parser = { workspace = true }
 biome_css_syntax = { workspace = true }