fix(lint/useHookAtTopLevel): detect early returns before calls to hooks #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs canceled.
|
github-actions
bot
added
A-Linter
ematipico
changed the title
Conaclos
changed the title
Conaclos
reviewed
Dec 5, 2023
crates/biome_js_analyze/src/semantic_analyzers/correctness/use_hook_at_top_level.rs
Outdated
Show resolved
Hide resolved
ematipico
reviewed
Dec 6, 2023
crates/biome_js_analyze/src/semantic_analyzers/correctness/use_hook_at_top_level.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/semantic_analyzers/correctness/use_hook_at_top_level.rs
Show resolved
Hide resolved
crates/biome_js_analyze/src/semantic_analyzers/correctness/use_hook_at_top_level.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Dec 7, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements early return detection for the
useHookAtTopLevelrule. This is an important feature to prevent conditional hook invocations.Since the rule was already able to track hook invocations across function calls, I needed an additional model for tracking early returns in all functions, which lead to a bit of a complex solution that requires 3 visitors. I'm open to suggestions if this can be simplified :)
Fixes #696.
Test Plan
Test cases have been added.