fix(js_formatter): Allow JSX expressions to nestle on arrow chains #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rad-torte-839a59 canceled.
|
github-actions
bot
added
A-Formatter
Conaclos
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1024.
JSX Expressions are similar to objects, arrows, and function expressions for arrow chain bodies, where they can render their initial tag on the same line as the end of the arrow chain signatures. This was already supported for single arrow expressions, but the logic didn't carry over into the Chain layout.
This also addresses a big diff in a Prettier test about arrow chains within jsx expressions, and adds the same logic for inserting a soft line break at the end of the expression, again matching the Single layout that already existed.
Test Plan
Prettier diff snapshot is deleted because they now match. Also added a spec test to ensure it continues working as expected.