fix(js_formatter): fix binaryish and ts type handling for grouping call arguments #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs canceled.
|
github-actions
bot
added
A-Formatter
faultyserver
changed the title
faultyserver
commented
Dec 12, 2023
| generic.type_arguments().map_or(None, |type_arguments| { | ||
| let argument_list = type_arguments.ts_type_argument_list(); | ||
| if argument_list.len() == 1 { | ||
| argument_list.first().map_or(None, |first| first.ok()) |
There was a problem hiding this comment.
This looks a little weird, but it's unwrapping Option<SyntaxResult<Node>> into just Option<Node> to match the structure of the rest of the types here.
faultyserver
force-pushed
the
faulty/group-first-logical
branch
from
d5c81f4
to
1923357
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When I added
is_relatively_short_argumentin #777, I addedJsBinaryExpressionas a match arm, but didn't realize that wouldn't encompass expressions likea ?? b, which are actuallyJsLogicalExpression. This PR just adds a similar arm to that function for handling logicals exactly like binaries, which matches Prettier'sisBinaryishfunction used in the same place.This PR also implements the missing half of Prettier's
isSimpleTsType, introspecting arrays and generic types to extract the core type before checking for simplicity.Test Plan
Added to the spec test for simple_arguments and grouping to cover logical expressions.