Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create biome_css_analyze crate #1462

Merged
merged 4 commits into from
Jan 8, 2024
Merged

feat: create biome_css_analyze crate #1462

merged 4 commits into from
Jan 8, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR adds a new crate biome_css_analyze.

It does contain:

  • test suite
  • initial infra for new lint rules
  • code generation

It doesn't contain:

  • documentation generation
  • configuration generation

Test Plan

CI to pass

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for biomejs canceled.

Name Link
🔨 Latest commit c5817b7
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/659bdfe85441360008518a6e

@github-actions github-actions bot added A-Linter Area: linter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS L-JSON Language: JSON and super languages labels Jan 8, 2024
@ematipico ematipico requested review from a team January 8, 2024 09:22
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13452 13452 0
Failed 4192 4192 0
Panics 2 2 0
Coverage 76.23% 76.23% 0.00%

Copy link

codspeed-hq bot commented Jan 8, 2024

CodSpeed Performance Report

Merging #1462 will not alter performance

Comparing feat/css-analyzer (c5817b7) with main (8ce8f4e)

Summary

✅ 91 untouched benchmarks

⁉️ 2 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/css-analyzer Change
⁉️ typescript.js[cached] 5 s N/A N/A
⁉️ typescript.js[uncached] 5.5 s N/A N/A

@github-actions github-actions bot added the L-JavaScript Language: JavaScript and super languages label Jan 8, 2024
@ematipico ematipico merged commit ad9e2d0 into main Jan 8, 2024
19 of 20 checks passed
@ematipico ematipico deleted the feat/css-analyzer branch January 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant