Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(website): sync minor differences with the english version #1515

Merged
merged 2 commits into from
Jan 10, 2024
Merged

docs(website): sync minor differences with the english version #1515

merged 2 commits into from
Jan 10, 2024

Conversation

makotot
Copy link
Contributor

@makotot makotot commented Jan 10, 2024 •
edited
Loading

Summary

Fix minor differences with the english version in internals/versioning.

Test Plan

@netlify Netlify
Copy link

netlify bot commented Jan 10, 2024 •
edited
Loading

✅ Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit a404bb8
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/659ed873aeb8870008ea00cd
😎 Deploy Preview https://deploy-preview-1515--biomejs.netlify.app/ja/internals/versioning
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the A-Website Area: website label Jan 10, 2024
@makotot makotot marked this pull request as ready for review January 10, 2024 17:35
@makotot makotot requested a review from a team as a code owner January 10, 2024 17:35
unvalley
unvalley approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@unvalley unvalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@makotot
Copy link
Contributor Author

makotot commented Jan 10, 2024

Sorry. It didn't pass lint, so I added a fix commit 🙏

@unvalley unvalley changed the title docs(ja): sync minor differences with the english version. docs(website): sync minor differences with the english version Jan 10, 2024
@unvalley unvalley merged commit e2b3a25 into biomejs:main Jan 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unvalley unvalley unvalley approved these changes

Assignees
No one assigned
Labels
A-Website Area: website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makotot @unvalley