chore: rename `rome_flags` to `biome_flags`, `rome_aria_metadata` to`biome_aria_metadata` and `rome_aria` to`biome_aria` biomejs#88 #170

kyu08 · 2023-09-06T15:36:34Z

Summary

rename rome_flags to biome_flags
rename rome_aria_metadata to biome_aria_metadata
rename rome_aria to tobiome_aria

#88

Test Plan

just ready

ematipico · 2023-09-06T19:50:53Z

Thank you! It seems that there are conflicts now

kyu08 · 2023-09-07T00:41:59Z

@ematipico
I'm done! Could you check it please?

kyu08 · 2023-09-07T10:06:01Z

It seems like there are conflicts again and I realize there are errors provided by linter. I'll fix it later.

ematipico · 2023-09-07T11:14:57Z

Run the command just format to format all files, .toml files included;

kyu08 · 2023-09-07T11:15:09Z

I fixed conflicts but still got errors provided by executing just ready so I'll fix it later.

ematipico · 2023-09-07T11:16:25Z

I fixed conflicts but still got errors provided by executing just ready so I'll fix it later.

It seems that there's only a Cargo.lock issue. You're almost there! 😄

kyu08 · 2023-09-07T14:50:52Z

@ematipico
Thanks!
When I ran just ready, I got these errors.

All errors and warnings I got

   --> crates/rome_js_semantic/src/events.rs:126:36
    |
126 | /// Extracts [SemanticEvent] from [SyntaxNode].
    |                                    ^^^^^^^^^^ no item named `SyntaxNode` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
    = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default

warning: public documentation for `SemanticEventExtractor` links to private item `SemanticEventIterator`
   --> crates/rome_js_semantic/src/events.rs:134:76
    |
134 | /// For a simpler way to extract [SemanticEvent] see [semantic_events] or [SemanticEventIterator].
    |                                                                            ^^^^^^^^^^^^^^^^^^^^^ this item is private
    |
    = note: this link will resolve properly if you pass `--document-private-items`
    = note: `#[warn(rustdoc::private_intra_doc_links)]` on by default

warning: unresolved link to `PreOrder`
   --> crates/rome_js_semantic/src/events.rs:137:10
    |
137 | /// the [PreOrder] of the tree, and must pull events until [Pop] returns [None].
    |          ^^^^^^^^ no item named `PreOrder` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

warning: unresolved link to `Pop`
   --> crates/rome_js_semantic/src/events.rs:137:61
    |
137 | /// the [PreOrder] of the tree, and must pull events until [Pop] returns [None].
    |                                                             ^^^ no item named `Pop` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

warning: unresolved link to `SyntaxNode`
    --> crates/rome_js_semantic/src/events.rs:1036:36
     |
1036 | /// Extracts [SemanticEvent] from [SyntaxNode].
     |                                    ^^^^^^^^^^ no item named `SyntaxNode` in scope
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

warning: unresolved link to `SyntaxNode`
 --> crates/rome_js_semantic/src/semantic_model/builder.rs:6:63
  |
6 | /// Builds the [SemanticModel] consuming [SemanticEvent] and [SyntaxNode].
  |                                                               ^^^^^^^^^^ no item named `SyntaxNode` in scope
  |
  = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

warning: unresolved link to `SemanticEvents`
 --> crates/rome_js_semantic/src/semantic_model/builder.rs:9:46
  |
9 | /// [SemanticModelBuilder] consumes all the [SemanticEvents] and build all the
  |                                              ^^^^^^^^^^^^^^ no item named `SemanticEvents` in scope
  |
  = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

warning: public documentation for `SemanticModelBuilder` links to private item `SemanticModelData`
  --> crates/rome_js_semantic/src/semantic_model/builder.rs:10:32
   |
10 | /// data necessary to build a [SemanticModelData], that is allocated with an [Arc]
   |                                ^^^^^^^^^^^^^^^^^ this item is private
   |
   = note: this link will resolve properly if you pass `--document-private-items`

warning: unresolved link to `Arc`
  --> crates/rome_js_semantic/src/semantic_model/builder.rs:10:79
   |
10 | /// data necessary to build a [SemanticModelData], that is allocated with an [Arc]
   |                                                                               ^^^ no item named `Arc` in scope
   |
   = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

warning: public documentation for `SemanticModel` links to private item `scope`
   --> crates/rome_js_semantic/src/semantic_model/model.rs:105:15
    |
105 | /// - Scope: [scope]
    |               ^^^^^ this item is private
    |
    = note: this link will resolve properly if you pass `--document-private-items`

warning: unresolved link to `declaration`
   --> crates/rome_js_semantic/src/semantic_model/model.rs:106:22
    |
106 | /// - Declarations: [declaration]
    |                      ^^^^^^^^^^^ no item named `declaration` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

warning: public documentation for `SemanticModel` links to private item `SemanticModelData`
   --> crates/rome_js_semantic/src/semantic_model/model.rs:108:10
    |
108 | /// See [SemanticModelData] for more information about the internals.
    |          ^^^^^^^^^^^^^^^^^ this item is private
    |
    = note: this link will resolve properly if you pass `--document-private-items`

warning: unresolved link to `Call`
   --> crates/rome_js_semantic/src/semantic_model/model.rs:341:22
    |
341 |     /// Returns all [Call] of a [AnyJsFunction].
    |                      ^^^^ no item named `Call` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

warning: unresolved link to `Call`
   --> crates/rome_js_semantic/src/semantic_model/reference.rs:105:38
    |
105 |     /// Returns this reference as a [Call] if possible
    |                                      ^^^^ no item named `Call` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

warning: unresolved link to `ancestors`
   --> crates/rome_js_semantic/src/semantic_model/scope.rs:100:15
    |
100 |     /// that [ancestors] return "self" as the first scope,
    |               ^^^^^^^^^ no item named `ancestors` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

warning: unresolved link to `semantic_model::SemanticModel::scope`
   --> crates/rome_js_semantic/src/semantic_model/scope.rs:208:21
    |
208 |     /// See [scope](semantic_model::SemanticModel::scope)
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `semantic_model` is a function, not a module or type, and cannot have associated items

warning: unresolved link to `semantic_model::SemanticModel::scope_hoisted_to`
   --> crates/rome_js_semantic/src/semantic_model/scope.rs:212:21
    |
212 |     /// See [scope](semantic_model::SemanticModel::scope_hoisted_to)
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `semantic_model` is a function, not a module or type, and cannot have associated items

warning: unclosed HTML tag `bool`
   --> crates/rome_js_semantic/src/semantic_model/model.rs:298:65
    |
298 |     /// When a reference is specified this method returns Option<bool>,
    |                                                                 ^^^^^^
    |
    = note: `#[warn(rustdoc::invalid_html_tags)]` on by default
help: try marking as source code
    |
298 |     /// When a reference is specified this method returns `Option<bool>`,
    |                                                           +            +

warning: unclosed HTML tag `bool`
   --> crates/rome_js_semantic/src/semantic_model/model.rs:312:65
    |
312 |     /// When a reference is specified this method returns Option<bool>,
    |                                                                 ^^^^^^
    |
help: try marking as source code
    |
312 |     /// When a reference is specified this method returns `Option<bool>`,
    |                                                           +            +

   --> crates/rome_service/src/configuration/linter/rules.rs:371:5
    |
371 |     #[doc = "The scope prop should be used only on <th> elements."]
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(rustdoc::invalid_html_tags)]` on by default

warning: unclosed HTML tag `T`
    --> crates/rome_service/src/configuration/linter/rules.rs:2914:5
     |
2914 |     #[doc = "When expressing array types, this rule promotes the usage of T[] shorthand instead of Array<T>."]
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
help: try marking as source code
     |
2914 |     `#[doc = "When expressing array types, this rule promotes the usage of T[] shorthand instead of Array<T>."]`
     |     +                                                                                                          +
  --> crates/rome_json_formatter/src/generated.rs:23:57
   |
23 |             crate::json::auxiliary::root::FormatJsonRoot::default(),
   |                                                         ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
   = note: `-D clippy::default-constructed-unit-structs` implied by `-D warnings`

error: use of `default` to create a unit struct
  --> crates/rome_json_formatter/src/generated.rs:35:57
   |
35 |             crate::json::auxiliary::root::FormatJsonRoot::default(),
   |                                                         ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
  --> crates/rome_json_formatter/src/generated.rs:61:68
   |
61 |             crate::json::value::string_value::FormatJsonStringValue::default(),
   |                                                                    ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
  --> crates/rome_json_formatter/src/generated.rs:73:68
   |
73 |             crate::json::value::string_value::FormatJsonStringValue::default(),
   |                                                                    ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
  --> crates/rome_json_formatter/src/generated.rs:99:70
   |
99 |             crate::json::value::boolean_value::FormatJsonBooleanValue::default(),
   |                                                                      ^^^^^^^^^^^ help: remove this call to `default`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:111:70
    |
111 |             crate::json::value::boolean_value::FormatJsonBooleanValue::default(),
    |                                                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:137:64
    |
137 |             crate::json::value::null_value::FormatJsonNullValue::default(),
    |                                                                ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:149:64
    |
149 |             crate::json::value::null_value::FormatJsonNullValue::default(),
    |                                                                ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:175:68
    |
175 |             crate::json::value::number_value::FormatJsonNumberValue::default(),
    |                                                                    ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:187:68
    |
187 |             crate::json::value::number_value::FormatJsonNumberValue::default(),
    |                                                                    ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:213:66
    |
213 |             crate::json::value::array_value::FormatJsonArrayValue::default(),
    |                                                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:225:66
    |
225 |             crate::json::value::array_value::FormatJsonArrayValue::default(),
    |                                                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:251:68
    |
251 |             crate::json::value::object_value::FormatJsonObjectValue::default(),
    |                                                                    ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:263:68
    |
263 |             crate::json::value::object_value::FormatJsonObjectValue::default(),
    |                                                                    ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:283:61
    |
283 |             crate::json::auxiliary::member::FormatJsonMember::default(),
    |                                                             ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:295:61
    |
295 |             crate::json::auxiliary::member::FormatJsonMember::default(),
    |                                                             ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:321:70
    |
321 |             crate::json::auxiliary::member_name::FormatJsonMemberName::default(),
    |                                                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:333:70
    |
333 |             crate::json::auxiliary::member_name::FormatJsonMemberName::default(),
    |                                                                      ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:346:79
    |
346 |             crate::json::lists::array_element_list::FormatJsonArrayElementList::default(),
    |                                                                               ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:358:79
    |
358 |             crate::json::lists::array_element_list::FormatJsonArrayElementList::default(),
    |                                                                               ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:371:66
    |
371 |             crate::json::lists::member_list::FormatJsonMemberList::default(),
    |                                                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:383:66
    |
383 |             crate::json::lists::member_list::FormatJsonMemberList::default(),
    |                                                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:401:80
    |
401 |         FormatRefWithRule::new(self, crate::json::bogus::bogus::FormatJsonBogus::default())
    |                                                                                ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:410:82
    |
410 |         FormatOwnedWithRule::new(self, crate::json::bogus::bogus::FormatJsonBogus::default())
    |                                                                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:435:66
    |
435 |             crate::json::bogus::bogus_value::FormatJsonBogusValue::default(),
    |                                                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:447:66
    |
447 |             crate::json::bogus::bogus_value::FormatJsonBogusValue::default(),
    |                                                                  ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:458:81
    |
458 |         FormatRefWithRule::new(self, crate::json::any::value::FormatAnyJsonValue::default())
    |                                                                                 ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: use of `default` to create a unit struct
   --> crates/rome_json_formatter/src/generated.rs:467:83
    |
467 |         FormatOwnedWithRule::new(self, crate::json::any::value::FormatAnyJsonValue::default())
    |                                                                                   ^^^^^^^^^^^ help: remove this call to `default`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

error: could not compile `rome_json_formatter` (lib) due to 28 previous errors

Caused by:
  process didn't exit successfully: `/Users/${user_name}/.rustup/toolchains/1.72.0-aarch64-apple-darwin/bin/clippy-driver /Users/${user_name}/.rustup/toolchains/1.72.0-aarch64-apple-darwin/bin/rustc --crate-name rome_json_formatter --edition=2021 crates/rome_json_formatter/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --diagnostic-width=200 --crate-type lib --emit=dep-info,metadata -C embed-bitcode=no -C debuginfo=2 -C split-debuginfo=unpacked -C metadata=dd09da42e57b6561 -C extra-filename=-dd09da42e57b6561 --out-dir /Users/${user_name}/code/rust/biome/target/debug/deps -C incremental=/Users/${user_name}/code/rust/biome/target/debug/incremental -L dependency=/Users/${user_name}/code/rust/biome/target/debug/deps --extern rome_diagnostics=/Users/${user_name}/code/rust/biome/target/debug/deps/librome_diagnostics-a0a6d7d36596e856.rmeta --extern rome_formatter=/Users/${user_name}/code/rust/biome/target/debug/deps/librome_formatter-9e1f1d186349a0f6.rmeta --extern rome_json_syntax=/Users/${user_name}/code/rust/biome/target/debug/deps/librome_json_syntax-7bef5e14e53f2491.rmeta --extern rome_rowan=/Users/${user_name}/code/rust/biome/target/debug/deps/librome_rowan-c5d14f863285342f.rmeta --extern rome_suppression=/Users/${user_name}/code/rust/biome/target/debug/deps/librome_suppression-03397d5fefec1ea1.rmeta` (exit status: 1)
warning: build failed, waiting for other jobs to finish...
error: Recipe `lint` failed on line 102 with exit code 101
error: Recipe `ready` failed on line 110 with exit code 101

At first, I'll try to fix errors and warnings I might be able to fix.
And I don't have any idea to fix some of them like below. Please help me! 🙇

1

It seems like public documentation references a private item. (I have no idea to fix this. Please Help! 🙇‍♂️)

warning: public documentation for `SemanticEventExtractor` links to private item `SemanticEventIterator`
   --> crates/rome_js_semantic/src/events.rs:134:76
    |
134 | /// For a simpler way to extract [SemanticEvent] see [semantic_events] or [SemanticEventIterator].
    |                                                                            ^^^^^^^^^^^^^^^^^^^^^ this item is private
    |
    = note: this link will resolve properly if you pass `--document-private-items`
    = note: `#[warn(rustdoc::private_intra_doc_links)]` on by default

2

What I should do is just escape like \[PreOrder\]? Or this reference is invalid?

warning: unresolved link to `PreOrder`
   --> crates/rome_js_semantic/src/events.rs:137:10
    |
137 | /// the [PreOrder] of the tree, and must pull events until [Pop] returns [None].
    |          ^^^^^^^^ no item named `PreOrder` in scope
    |
    = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

3

I don't have any idea to fix this. 🙇‍♂️

warning: unresolved link to `semantic_model::SemanticModel::scope`
   --> crates/rome_js_semantic/src/semantic_model/scope.rs:208:21
    |
208 |     /// See [scope](semantic_model::SemanticModel::scope)
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `semantic_model` is a function, not a module or type, and cannot have associated items

4

It seems like I should update codes as source code like help shows.

warning: unclosed HTML tag `bool`
   --> crates/rome_js_semantic/src/semantic_model/model.rs:298:65
    |
298 |     /// When a reference is specified this method returns Option<bool>,
    |                                                                 ^^^^^^
    |
    = note: `#[warn(rustdoc::invalid_html_tags)]` on by default
help: try marking as source code
    |
298 |     /// When a reference is specified this method returns `Option<bool>`,
    |                                                           +            +

kyu08 · 2023-09-07T15:34:45Z

I fixed all errors and warnings that I could fix and CI passed! (I realized that simply I did't have to push diff of the file **/generated.rs. But it seems weird that executing just ready generates codes that don't pass CI).

If it is not big problem, is it possible to leave some warnings I showed above?

kyu08 · 2023-09-07T15:38:58Z

Oops! I realize that I pushed needless changes(crates/rome_js_formatter/src/generated.rs and crates/rome_json_formatter/src/generated.rs).
I'll fix them soon.

kyu08 · 2023-09-07T15:48:46Z

@ematipico
I'm done. Could you please review it?

nissy-dev

Thanks! LGTM 👍

kyu08 · 2023-09-08T01:54:18Z

@ematipico @nissy-dev
Thank you for reviewing and helping me! ☺️

github-actions bot added A-CLI Area: CLI A-Project Area: project A-Tooling Area: internal tools labels Sep 6, 2023

kyu08 marked this pull request as draft September 6, 2023 15:37

kyu08 force-pushed the feat/rename-crates branch from 9c80b6a to b345760 Compare September 6, 2023 15:38

kyu08 changed the title ~~chore: rename rome_flags to biome_flags biomejs#88~~ chore: rename rome_flags to biome_flags #88 Sep 6, 2023

kyu08 changed the title ~~chore: rename rome_flags to biome_flags #88~~ chore: rename rome_flags to biome_flags biomejs#88 Sep 6, 2023

kyu08 marked this pull request as ready for review September 6, 2023 15:55

kyu08 force-pushed the feat/rename-crates branch from b345760 to ef93122 Compare September 6, 2023 16:11

kyu08 changed the title ~~chore: rename rome_flags to biome_flags biomejs#88~~ chore: rename rome_flags to biome_flags and rome_aria_metadata to biome_aria_metadata biomejs#88 Sep 6, 2023

kyu08 changed the title ~~chore: rename rome_flags to biome_flags and rome_aria_metadata to biome_aria_metadata biomejs#88~~ chore: rename rome_flags to biome_flags and rome_aria_metadata tobiome_aria_metadata biomejs#88 Sep 6, 2023

github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Sep 6, 2023

kyu08 changed the title ~~chore: rename rome_flags to biome_flags and rome_aria_metadata tobiome_aria_metadata biomejs#88~~ chore: rename rome_flags to biome_flags, rome_aria_metadata tobiome_aria_metadata and rome_aria tobiome_aria biomejs#88 Sep 6, 2023

kyu08 temporarily deployed to Website deployment September 6, 2023 18:09 — with GitHub Actions Inactive

kyu08 force-pushed the feat/rename-crates branch from 5b25a8d to 6fabacb Compare September 7, 2023 00:29

kyu08 temporarily deployed to Website deployment September 7, 2023 03:20 — with GitHub Actions Inactive

kyu08 force-pushed the feat/rename-crates branch from 6fabacb to 88ccaaa Compare September 7, 2023 05:12

kyu08 temporarily deployed to Website deployment September 7, 2023 05:27 — with GitHub Actions Inactive

kyu08 force-pushed the feat/rename-crates branch from 88ccaaa to 6149e4d Compare September 7, 2023 10:56

kyu08 temporarily deployed to Website deployment September 7, 2023 11:00 — with GitHub Actions Inactive

kyu08 temporarily deployed to Website deployment September 7, 2023 11:08 — with GitHub Actions Inactive

github-actions bot added the A-Formatter Area: formatter label Sep 7, 2023

github-actions bot added the L-JSON Language: JSON and super languages label Sep 7, 2023

kyu08 force-pushed the feat/rename-crates branch from 372151e to de62d80 Compare September 7, 2023 15:08

kyu08 force-pushed the feat/rename-crates branch from e6ef3e9 to 5eecf7d Compare September 7, 2023 15:42

github-actions bot removed the A-Formatter Area: formatter label Sep 7, 2023

kyu08 added 7 commits September 8, 2023 00:51

chore: rename rome_flags to biome_flags biomejs#88

34c5800

chore: rename rome_aria_metadata to biome_aria_metadata biomejs#88

44a20ca

chore: rename rome_aria to biome_aria biomejs#88

6c086fc

run just format

d051c08

fix to symbols as source code in comment

43842dc

run just ready

97c4846

format

00dd41c

kyu08 force-pushed the feat/rename-crates branch from 5eecf7d to 00dd41c Compare September 7, 2023 15:53

format

72933f9

nissy-dev approved these changes Sep 8, 2023

View reviewed changes

nissy-dev merged commit f243c7b into biomejs:main Sep 8, 2023
13 checks passed

kyu08 deleted the feat/rename-crates branch September 8, 2023 01:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: rename `rome_flags` to `biome_flags`, `rome_aria_metadata` to`biome_aria_metadata` and `rome_aria` to`biome_aria` biomejs#88 #170

chore: rename `rome_flags` to `biome_flags`, `rome_aria_metadata` to`biome_aria_metadata` and `rome_aria` to`biome_aria` biomejs#88 #170

kyu08 commented Sep 6, 2023 •

edited

Loading

ematipico commented Sep 6, 2023

kyu08 commented Sep 7, 2023 •

edited

Loading

kyu08 commented Sep 7, 2023 •

edited

Loading

ematipico commented Sep 7, 2023 •

edited

Loading

kyu08 commented Sep 7, 2023

ematipico commented Sep 7, 2023

kyu08 commented Sep 7, 2023

kyu08 commented Sep 7, 2023

kyu08 commented Sep 7, 2023

kyu08 commented Sep 7, 2023

nissy-dev left a comment

kyu08 commented Sep 8, 2023

chore: rename rome_flags to biome_flags, rome_aria_metadata tobiome_aria_metadata and rome_aria tobiome_aria biomejs#88 #170

chore: rename rome_flags to biome_flags, rome_aria_metadata tobiome_aria_metadata and rome_aria tobiome_aria biomejs#88 #170

Conversation

kyu08 commented Sep 6, 2023 • edited Loading

Summary

Test Plan

ematipico commented Sep 6, 2023

kyu08 commented Sep 7, 2023 • edited Loading

kyu08 commented Sep 7, 2023 • edited Loading

ematipico commented Sep 7, 2023 • edited Loading

kyu08 commented Sep 7, 2023

ematipico commented Sep 7, 2023

kyu08 commented Sep 7, 2023

1

2

3

4

kyu08 commented Sep 7, 2023

kyu08 commented Sep 7, 2023

kyu08 commented Sep 7, 2023

nissy-dev left a comment

Choose a reason for hiding this comment

kyu08 commented Sep 8, 2023

chore: rename `rome_flags` to `biome_flags`, `rome_aria_metadata` to`biome_aria_metadata` and `rome_aria` to`biome_aria` biomejs#88 #170

chore: rename `rome_flags` to `biome_flags`, `rome_aria_metadata` to`biome_aria_metadata` and `rome_aria` to`biome_aria` biomejs#88 #170

kyu08 commented Sep 6, 2023 •

edited

Loading

kyu08 commented Sep 7, 2023 •

edited

Loading

kyu08 commented Sep 7, 2023 •

edited

Loading

ematipico commented Sep 7, 2023 •

edited

Loading