Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename rome_analyze -> biome_analyze #88 #177

Closed
wants to merge 2 commits into from

Conversation

ekusiadadus
Copy link
Contributor

Summary

  • rename rome_analyze -> biome_analyze

#88

Test Plan

I have executed cargo test.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter A-Tooling Area: internal tools A-LSP Area: language server protocol L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages labels Sep 7, 2023
@ematipico
Copy link
Member

@ekusiadadus

For the testing plan, I suggest using just ready. The reason is the following: there's a lot of generated code and formatting around this crate, that they could be easy to miss. That's why the CI fails.

@ekusiadadus
Copy link
Contributor Author

@ematipico

Thank you for the review!

But, What does 'just ready' mean?

@ematipico
Copy link
Member

You can read more about it in our guide: https:/biomejs/biome/blob/main/CONTRIBUTING.md#install-the-required-tools

We use just, which is a script runner. And we have a script called ready, which you can run by typing the command just ready. The command runs various things: code generation, tests, format, etc. Essentially it runs all the scripts we run in CI

@ekusiadadus ekusiadadus closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Linter Area: linter A-LSP Area: language server protocol A-Project Area: project A-Tooling Area: internal tools L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants