refactor(formatter): improve string normalization #3564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While I was working on #3558, I noted a room for improving string utilities.
This PR improves the implementation of the string utilities:
The PR has also the aim of improving performance of string normalization by avoiding
peekable()
and iterating over bytes instead of chars.The PR also normalizes strings before evaluating if quotes are needed for import attribute keys.
This is a follow-up of #3558.
There is more room for improvements for example to avoid code duplication.
The change are already large in this PR, I prefer to defer them in a follow-up PR.
Test Plan
I improved the test coverage of the
normalise_string
function.