Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser/html): check void element names case insensitively #3959

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix(parser/html): check void element names case insensitively #3959

merged 1 commit into from
Sep 17, 2024

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 17, 2024

Summary

The HTML spec says that the casing of html tags is case insensitive.

Test Plan

CI should pass. Added a test.

@github-actions github-actions bot added A-Parser Area: parser L-HTML Language: HTML labels Sep 17, 2024
@dyc3 dyc3 requested review from a team September 17, 2024 17:00
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 17, 2024

CodSpeed Performance Report

Merging #3959 will improve performances by 7.09%

Comparing 09-17-fix_parser_html_check_void_element_names_case_insensitively (cf87aa4) with main (e3b6faf)

Summary

⚡ 1 improvements
✅ 106 untouched benchmarks

Benchmarks breakdown

Benchmark main 09-17-fix_parser_html_check_void_element_names_case_insensitively Change
⚡ db_17847247775464589309.json[uncached] 16.3 ms 15.2 ms +7.09%

@dyc3 dyc3 merged commit a6daf64 into main Sep 17, 2024
15 checks passed
@dyc3 dyc3 deleted the 09-17-fix_parser_html_check_void_element_names_case_insensitively branch September 17, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conaclos Conaclos Conaclos approved these changes

Assignees
No one assigned
Labels
A-Parser Area: parser L-HTML Language: HTML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyc3 @Conaclos