Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build x86_64-unknown-linux-musl and aarch64-unknown-linux-musl #821

Merged
merged 27 commits into from
Nov 22, 2023

Conversation

nhedger
Copy link
Member

@nhedger nhedger commented Nov 21, 2023

Summary

This pull request extends the build matrix to support the following targets:

  • x86_64-unknown-linux-musl
  • aarch64-unknown-linux-musl

This opens up the possibility of distributing an Alpine-based docker image of Biome.


Fixes #823

@nhedger nhedger changed the title feat: build for alpine feat: build forx86_64-unknown-linux-musl Nov 21, 2023
@nhedger
Copy link
Member Author

nhedger commented Nov 21, 2023

Related: #747

@nhedger nhedger changed the title feat: build forx86_64-unknown-linux-musl feat: build forunknown-linux-musl Nov 22, 2023
@github-actions github-actions bot added the A-CLI Area: CLI label Nov 22, 2023
@github-actions github-actions bot added the A-Tooling Area: internal tools label Nov 22, 2023
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 592 592 0
Failed 70 70 0
Panics 0 0 0
Coverage 89.43% 89.43% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13454 13454 0
Failed 4190 4190 0
Panics 2 2 0
Coverage 76.24% 76.24% 0.00%

@nhedger nhedger changed the title feat: build forunknown-linux-musl ci: build amd64-unknown-linux-musl and aarch64-unknown-linux-musl Nov 22, 2023
@nhedger nhedger marked this pull request as ready for review November 22, 2023 12:23
@nhedger nhedger requested review from a team November 22, 2023 12:23
@nhedger nhedger changed the title ci: build amd64-unknown-linux-musl and aarch64-unknown-linux-musl ci: build x86_64-unknown-linux-musl and aarch64-unknown-linux-musl Nov 22, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you @nhedger

A reminder to update the supported platforms. I think we can push a commit straight to release/1.4.0

@nhedger nhedger merged commit 38797b7 into main Nov 22, 2023
16 checks passed
@nhedger nhedger deleted the feat/alpine branch November 22, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Tooling Area: internal tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build for Alpine Linux/musl
2 participants