Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle unimplemented file capabilities slightly more gracefully #1089

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 11, 2024

Summary

The HTML language currently doesn't implement some of the file capabilities that the playground expects. This makes it so that a language does not need to implement some of these capabilities in order to work in the playground, requiring less code changes. Ideally though, we would grab the file capabilities from biome instead of try/catching. (This has been reworked to do so.)

This doesn't make HTML fully functional in the playground -- other things in biome needs to be implemented first. Once this is merged, HTML will be fully functional in the playground (for the features that are implemented)

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit bae0f9b
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/66ed8299e255760008ae5e4b
😎 Deploy Preview https://deploy-preview-1089--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ematipico
Copy link
Member

Ideally though, we would grab the file capabilities from biome instead of try/catching.

This is actually possible. The workspace provides a method for that

@dyc3
Copy link
Contributor Author

dyc3 commented Sep 13, 2024

Ah, then I will rework this to do that.

@dyc3 dyc3 marked this pull request as draft September 13, 2024 09:07
@dyc3
Copy link
Contributor Author

dyc3 commented Sep 13, 2024

It looks like the fileFeatures function doesn't currently indicate if the language supports parsing, control flow graph, or formatter ir.

@dyc3 dyc3 force-pushed the 09-11-fix_handle_unimplemented_file_capabilities_slightly_more_gracefully branch from 58f3207 to 8de67e0 Compare September 14, 2024 15:04
@dyc3 dyc3 marked this pull request as ready for review September 18, 2024 15:46
@dyc3 dyc3 force-pushed the 09-11-fix_handle_unimplemented_file_capabilities_slightly_more_gracefully branch 4 times, most recently from 48a9366 to 77476c8 Compare September 20, 2024 11:25
@dyc3
Copy link
Contributor Author

dyc3 commented Sep 20, 2024

Now that the other PRs in biome are merged, everything should be good to go here.

@dyc3 dyc3 requested review from a team September 20, 2024 11:27
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would use the message "Not supported" instead. The word "available" doesn't fit the case, I think. I would address @Princesseuh 's comment

@dyc3 dyc3 force-pushed the 09-11-fix_handle_unimplemented_file_capabilities_slightly_more_gracefully branch from 77476c8 to bae0f9b Compare September 20, 2024 14:11
@dyc3 dyc3 merged commit 144008d into main Sep 20, 2024
6 checks passed
@dyc3 dyc3 deleted the 09-11-fix_handle_unimplemented_file_capabilities_slightly_more_gracefully branch September 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants