Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom fee rate field when custom inputs are used #5483

Merged
merged 3 commits into from
May 11, 2021
Merged

Fix custom fee rate field when custom inputs are used #5483

merged 3 commits into from
May 11, 2021

Conversation

BtcContributor
Copy link
Contributor

@BtcContributor BtcContributor commented May 11, 2021 •
edited
Loading

If a user chooses to use custom inputs in Funds menu, custom fee rate field is wrongly blanked and this leads to NumberFormatException.

Fixed by updating inputsToggleGroupListener

Thanks @jmacxx for having pointed out this.

ripcurlx
ripcurlx approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.6.5 milestone May 11, 2021
@ripcurlx ripcurlx merged commit 68f4ec1 into bisq-network:master May 11, 2021
@BtcContributor BtcContributor deleted the custominput_customfee branch May 11, 2021 14:20
@BtcContributor BtcContributor mentioned this pull request May 17, 2021
Merged
@BtcContributor BtcContributor mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.5
Development

Successfully merging this pull request may close these issues.
2 participants
@BtcContributor @ripcurlx