Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdrawal view: reduce vertical spacing and fix issue with custom fee #5512

Merged
merged 1 commit into from May 20, 2021
Merged

Withdrawal view: reduce vertical spacing and fix issue with custom fee #5512

merged 1 commit into from May 20, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 19, 2021

  • Reduce the vertical spacing in order to show the custom inputs table on smaller screens.
  • Reduce vertical space used by showing the custom fee toggle to the right of its input box.
  • Don't reset the user's chosen fee rate when clicking in the table or the custom input radio button.
  • Don't overwrite the user's custom fee with FeeService updates.

Fixes: #5457

Before fix:
image

After fix:
image

@ripcurlx ripcurlx added this to the v1.6.5 milestone May 19, 2021
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit c6e2b2c into bisq-network:master May 20, 2021
@ghost ghost mentioned this pull request Jun 5, 2021
@ghost ghost deleted the fix_withdraw_fee_update branch May 29, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to send funds from custom inputs (low res screens) (v1.6.3)
1 participant