Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List RSK Smart Bitcoin (R-BTC) #5611

Merged
merged 2 commits into from
Jul 13, 2021
Merged

List RSK Smart Bitcoin (R-BTC) #5611

merged 2 commits into from
Jul 13, 2021

Conversation

harrigan
Copy link
Contributor

@harrigan harrigan commented Jul 8, 2021

Asset name

RSK Smart Bitcoin

Ticker

R-BTC

Website

https://www.rsk.co/

Block explorer

https://explorer.rsk.co/

Additional technical requirements

There are no additional technical requirements.

@boring-cyborg boring-cyborg bot added in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now labels Jul 8, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 8, 2021

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

@harrigan
Copy link
Contributor Author

harrigan commented Jul 8, 2021

For background, this pull request is part of an entry to the Sovryn Hackathon to provide a gateway in and out of the RSK sidechain. At the moment, the only way to exchange BTC for R-BTC is via centralised exchanges and relays, or via the decentralised but slow and technical RSK Powpeg. Bisq would provide a useful alternative.

chimp1984
chimp1984 previously approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@chimp1984 chimp1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

ripcurlx
ripcurlx previously approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx
Copy link
Contributor

@harrigan There is a minor tab issue codacy is complaining about: https://app.codacy.com/gh/bisq-network/bisq/pullRequest?prid=7725154

@harrigan harrigan dismissed stale reviews from ripcurlx and chimp1984 via c78cd8b July 12, 2021 12:53
ripcurlx
ripcurlx approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx ripcurlx merged commit e4b00c6 into bisq-network:master Jul 13, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 13, 2021

Awesome work, congrats on your first merged pull request!

@ripcurlx ripcurlx added this to the v1.7.2 milestone Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@chimp1984 chimp1984 chimp1984 left review comments

Assignees
No one assigned
Labels
in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now
Projects
None yet
Milestone
v1.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@harrigan @ripcurlx @chimp1984