Move volume formatting from DisplayUtils to VolumeUtil #5740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, presentation/display logic should be kept in UIs, but the core api will need to duplicate a very small part of the code in DisplayUtils if a very small part of this refactoring is not done. Instead of moving a tiny bit of the volume formatting methods, all of them are moved to core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice, presentation/display logic should be kept in UIs, but the core api will need to duplicate a very small part of the code in
DisplayUtilsif a very small part of this refactoring is not done. Instead of moving a tiny bit of the volume formatting methods, all of them are moved to core'sVolumeUtil.This PR's branch is based off
master, and is not part of any PR chain requiring review/merge of any parent PRs.