Allow trader chat to continue after trade complete #5742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
|
@pazza83 @chimp1984 This PR would make it possible to open a chat again also from closed trades. I think it would be sufficient to not auto-close the chat window when it is open after a trade is completed. |
|
👍 I'm ok with removing the chat feature from closed trades, if that's what people want. |
|
Great thanks @jmacxx that you implemented that so fast! |
|
Discussed with support team, they prefer no chat on closed trades, so I reverted that feature. You'll still be able to chat until the chat window is closed. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trader chat no longer gets automatically closed at trade completion,
and traders can open it again from closed trades.[edit] no chat for
closedtrades, due to feedback received below.Fixes #5734