Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add penalty calculation to dispute agent UI #5834

Merged
merged 1 commit into from Nov 18, 2021
Merged

Add penalty calculation to dispute agent UI #5834

merged 1 commit into from Nov 18, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2021

Requested by @leo816 and @pazza83.
@refund-agent2 please review.

  • Adds penalty calculation options to the disputes UI.
  • Enables agents to apply penalties

Specifications

Screenshots

image

image

@leo816
Copy link

leo816 commented Nov 17, 2021

@refund-agent2 please review

@refund-agent2
Copy link

I can't review properly to make sure it works ok, but it seems ok to make it easier to apply the Penalties table. The only problem I find for my use of it is that it doesn''t include arbitration fees.

@ghost
Copy link
Author

ghost commented Nov 18, 2021

Thanks for your review comments here and on keybase.
I have made the suggestions WRT increasing the height of the summary text area to 8 lines, and removing 'loser as publisher' as it is no longer used. We can address arbitration fees with a future PR after discussion has taken place.

arbitration_screen

@ghost ghost marked this pull request as ready for review November 18, 2021 14:52
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.8.0 milestone Nov 18, 2021
@ripcurlx ripcurlx merged commit ef7ce10 into bisq-network:master Nov 18, 2021
@ghost ghost mentioned this pull request Dec 20, 2021
@ghost ghost deleted the dispute_ui_add_penalty branch October 18, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants