Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API BSQ swap simulation script and doc updates #5 #5876

Merged

Commits on Nov 11, 2021

  1. Adjust bsq-swap-offer related gRPC services & msgs

    - Adjust GetBsqSwapOffer(s) rpc services to remove currency param.
    - Adjust OfferInfo and remove BsqSwapOfferInfo.
    - Add GetOfferCategory service so CLI can determine what kind of takeoffer service is to be used.
    - Add comment about adding sub-message BsqSwapTradeInfo field to TradeInfo.
    ghubstan committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    5924312 View commit details
    Browse the repository at this point in the history
  2. Adjust bsq-swap-offer related gRPC daemon services

    - Add GetOfferCategory service so CLI can determine what kind of takeoffer service is to be used.
    - Adjust to removal of BsqSwapOfferInfo proto.
    - Call new coreApi.getRole(BsqSwapTrade) before building BsqSwapTradeInfo proto.
    ghubstan committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    c6aceb0 View commit details
    Browse the repository at this point in the history
  3. Partially adjust api proto wrappers for bsq-swap support

    - Complete BsqSwapTradeInfo impl.
    - Merge BsqSwapOfferInfo fields into OfferInfo and remove BsqSwapOfferInfo.
    - Change all model builders to private static class Builder.
    ghubstan committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    5d63fd7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    713b309 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    521495c View commit details
    Browse the repository at this point in the history
  6. Partially adjust core api for bsq-swap support

    - Add core api methods to help CLI determine which type of offer to
      take for a given offerId.  CLI's 'takeoffer` will need to determine
      which gRPC/proto request type to send to server.
    
    - Add implemetations for getBsqSwapTradeRole(), for tradeId or trade.
    ghubstan committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    3dfbf3f View commit details
    Browse the repository at this point in the history
  7. Paritally adjust bsq-swap-offer related gRPC CLI side classes

    - Adjust to removal of BsqSwapOfferInfo proto, use ammended OfferInfo instead.
    
    - Remove currency-code param from all get(My)BsqSwapOffer(s) requests.
    
    - Add new OfferCategory getAvailableOfferCategory(String offerId) service.
      CLI uses this to determine which kind of gRPC request object should be
      sent with a 'takeoffer' request.
    
    - Adjust GetOffersSmokeTest to help see offer/swap-offer CLI output.
    ghubstan committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    16be357 View commit details
    Browse the repository at this point in the history
  8. Paritally adjust bsq-swap-offer related apitest cases

    - Adjust to removal of BsqSwapOfferInfo proto, use ammended OfferInfo instead.
    - Remove currency-code param from all get(My)BsqSwapOffer(s) requests.
    ghubstan committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    c5f50b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2021

  1. Normalize API gRPC bsq-swap related protos & wrappers

    This commit refactors the first cut of the BsqSwapTradeInfo and
    TradeInfo gRPC proto defs and wrappers.  The change avoids duplication
    of fields between BsqSwapTradeInfo and TradeInfo, and adds a
    bsqSwapTradeInfo field to the old TradeInfo proto & wrapper.
    
    The immediate goal is moving towards getting the API's 'gettrade'
    method to work for both Bisq v1 trades and BSQ swap trades:  the TradeInfo
    proto sent to the CLI should represent either a Bisq v1 trade or a BSQ
    swap trade.  A mid-term term goal is to also make a new 'gettrades' method
    return a List<TradeInfo> to the CLI, where items in the List<TradeInfo>
    can be either v1 trades or bsq-swap trades.
    ghubstan committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    564303a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9f01279 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2021

  1. Add CLI output IntegerColumn

    ghubstan committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    fc53ca4 View commit details
    Browse the repository at this point in the history
  2. Adjust API 'gettrade' for Bsq swaps

    - Made several adjustments to CLI's 'gettrade' output related code
      so it can show single trade details for either Bisq v1 trades, or
      BSQ swap trades.
    
    - Did minor refactoring of API's core to retrieve # tx confirmations
      for an addresses and transactions.
    
    - Show # of tx confirmations in bsq swap trade detail.
    ghubstan committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    4ca878a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d8f1e44 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Configuration menu
    Copy the full SHA
    b65cc9c View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Remove Get/Take BSQSwap Offer/Trade rpc service defs

    The old GetTrade and TakeOffer rpc service defs will be used
    for getting BSQ swap trades, and taking BSQ swap offers.
    ghubstan committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    17277c4 View commit details
    Browse the repository at this point in the history
  2. Refactor GrpcTradesService: use GetTrade & TakeOffer services for BSQ…

    … swaps
    
    The rpc GetBsqSwapTrade and TakeBsqSwapOffer services were a quick hack
    to help test BSQ swap feature development more quickly, using apitest
    cases.  Their gRPC service method implementations are removed here and
    the GetTrade & TakeOffer service methods are refactored to support BSQ
    swaps.
    ghubstan committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    f88c151 View commit details
    Browse the repository at this point in the history
  3. Refactor core.api trade service implemenentations for BSQ swaps

    A minor refactoring to support serving TradeModel instances to CLI.
    For example, the CLI 'gettrade' command must return a v1 Trade or
    BSQ swap trade.
    ghubstan committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    3aae052 View commit details
    Browse the repository at this point in the history
  4. Adjust CLI to support getting/taking BSQ swaps

    Also refactored some of the opt parsers.
    ghubstan committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    0c5c343 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6403fc1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c177b3b View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Configuration menu
    Copy the full SHA
    00a5e2b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3077be5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b1c872c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    35aeb61 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    eff1084 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    15621d4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    132ecc9 View commit details
    Browse the repository at this point in the history
  8. Add CLI createoffer smoketest (for bsq swaps)

    NEVER RUN ON MAINNET!
    ghubstan committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    0aa0852 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Fix help text typo

    ghubstan committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    05d1916 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2021

  1. Make rpc GetOfferCategory service work for my+avail offers

    There are some use cases where the CLI needs to know what kind of offer
    is being acted on before the request is made, For example:
    
    There are differences between a BsqSwap 'takeoffer'request, and a v1
    'takeoffer' request.
    
    A BsqSwap offer cannot be edited by an 'editoffer' request, and an
    attempt should be blocked by the CLI.
    
    - Append isMyOffer GetOfferCategoryRequest rpc msg def.
    
    - Adjust daemon.grpc services for new boolean GetOfferCategoryRequest param.
    
    - Adjust core.api for new boolean GetOfferCategoryRequest param.
    
    - Add validation check in core.api EditOfferValidator to block attempt to
      edit a BsqSwap offer.
    
    - Refactor CoreOffersService get*offer(id) methods to optionally throw
      excpetions.
    ghubstan committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    64f228d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b95e4b3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    000fe9b View commit details
    Browse the repository at this point in the history
  4. There is no --swap opt in editoffer command

    BSQ swap offers cannot be edited
    ghubstan committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    b5981b5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0d8559d View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2021

  1. Revert "There is no --swap opt in editoffer command"

    This reverts commit b5981b5.
    
    This was a mistake.  There is a swap opt in the createoffer command.
    ghubstan committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    66115f3 View commit details
    Browse the repository at this point in the history
  2. Add apitest/scripts/bsqswap-simulation.sh script

    Some refactoring and typo corrections in existing scripts too.
    ghubstan committed Nov 28, 2021
    Configuration menu
    Copy the full SHA
    1b7e43a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8b2dec7 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. Configuration menu
    Copy the full SHA
    6b89254 View commit details
    Browse the repository at this point in the history
  2. Allow unrecognized options in OfferIdOptionParser where appropriate

    The OfferIdOptionParser superclass reduces duplication for parsing
    offer-id parameters, but it needs to let subclass parsers' other
    options pass validation.
    ghubstan committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    b1dd205 View commit details
    Browse the repository at this point in the history
  3. Update API docs for Bitcoin Core version v22.0

    Plus some outdated JDK version compat comments.
    ghubstan committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    a1db0d1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3015554 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Configuration menu
    Copy the full SHA
    946ca46 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2021

  1. Configuration menu
    Copy the full SHA
    bb68605 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f195b76 View commit details
    Browse the repository at this point in the history