Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase trade protocol timeout from 60 sec to 120 sec #5904

Merged
merged 1 commit into from
Dec 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public void handleTakeOfferRequest(InputsForDepositTxRequest message,
errorMessageHandler.handleErrorMessage(errorMessage);
handleTaskRunnerFault(message, errorMessage);
}))
.withTimeout(60))
.withTimeout(120))
.executeTasks();
}

Expand All @@ -105,7 +105,7 @@ protected void handle(DelayedPayoutTxSignatureRequest message, NodeAddress peer)
BuyerSignsDelayedPayoutTx.class,
BuyerFinalizesDelayedPayoutTx.class,
BuyerSendsDelayedPayoutTxSignatureResponse.class)
.withTimeout(60))
.withTimeout(120))
.executeTasks();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public void onTakeOffer() {
CreateTakerFeeTx.class,
BuyerAsTakerCreatesDepositTxInputs.class,
TakerSendInputsForDepositTxRequest.class)
.withTimeout(60))
.withTimeout(120))
.run(() -> {
processModel.setTempTradingPeerNodeAddress(trade.getTradingPeerNodeAddress());
processModel.getTradeManager().requestPersistence();
Expand All @@ -106,7 +106,7 @@ private void handle(InputsForDepositTxResponse message, NodeAddress peer) {
BuyerAsTakerSignsDepositTx.class,
BuyerSetupDepositTxListener.class,
BuyerAsTakerSendsDepositTxMessage.class)
.withTimeout(60))
.withTimeout(120))
.executeTasks();
}

Expand All @@ -120,7 +120,7 @@ protected void handle(DelayedPayoutTxSignatureRequest message, NodeAddress peer)
BuyerSignsDelayedPayoutTx.class,
BuyerFinalizesDelayedPayoutTx.class,
BuyerSendsDelayedPayoutTxSignatureResponse.class)
.withTimeout(60))
.withTimeout(120))
.executeTasks();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public void handleTakeOfferRequest(InputsForDepositTxRequest message,
errorMessageHandler.handleErrorMessage(errorMessage);
handleTaskRunnerFault(message, errorMessage);
}))
.withTimeout(60))
.withTimeout(120))
.executeTasks();
}

Expand All @@ -105,7 +105,7 @@ protected void handle(DepositTxMessage message, NodeAddress peer) {
SellerCreatesDelayedPayoutTx.class,
SellerSignsDelayedPayoutTx.class,
SellerSendDelayedPayoutTxSignatureRequest.class)
.withTimeout(60))
.withTimeout(120))
.executeTasks();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public void onTakeOffer() {
CreateTakerFeeTx.class,
SellerAsTakerCreatesDepositTxInputs.class,
TakerSendInputsForDepositTxRequest.class)
.withTimeout(60))
.withTimeout(120))
.executeTasks();
}

Expand All @@ -99,7 +99,7 @@ private void handle(InputsForDepositTxResponse message, NodeAddress peer) {
SellerCreatesDelayedPayoutTx.class,
SellerSignsDelayedPayoutTx.class,
SellerSendDelayedPayoutTxSignatureRequest.class)
.withTimeout(60))
.withTimeout(120))
.executeTasks();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ protected void handle(ShareBuyerPaymentAccountMessage message, NodeAddress peer)
VerifyPeersAccountAgeWitness.class))
.run(() -> {
// We stop timeout here and don't start a new one as the
// SellerSendsDepositTxAndDelayedPayoutTxMessage repeats the send the message and has it's own
// SellerSendsDepositTxAndDelayedPayoutTxMessage repeats to send the message and has it's own
// timeout if it never succeeds.
stopTimeout();
})
Expand Down