Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OfferBook: Show Complete Text Of Action Button If Enough Space Available #5907

Merged

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Dec 8, 2021

Even if the app is maximized it does not show the full text of the
action button if the text is long. Switching Bisq to German and
maximizing the window reveals the problem.

Fixes #5862

Even if the app is maximized it does not show the full text of the
action button if the text is long. Switching Bisq to German and
maximizing the window reveals the problem.

Fixes bisq-network#5862
@ripcurlx ripcurlx added this to the v1.8.1 milestone Dec 8, 2021
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK - Tested it on Mainnet

Bildschirmfoto 2021-12-09 um 10 18 31

Congrats to your first merged PR in Bisq!

@ripcurlx ripcurlx merged commit f3d2cc3 into bisq-network:master Dec 9, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 9, 2021

Awesome work, congrats on your first merged pull request!

@alvasw alvasw deleted the offer_book_action_button_text_cutoff branch February 6, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt column resizing policy in offer book
2 participants