Edit offer button #5955
Merged
Edit offer button #5955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
ripcurlx
previously approved these changes
Jan 11, 2022
| @@ -138,6 +143,7 @@ private void onEditOpenOfferRemoved() { | |||
| editOfferView = null; | |||
| } | |||
|
|
|||
| // navigation.navigateToPreviousVisitedView(); | |||
There was a problem hiding this comment.
Please remove unused code
Comment on lines
218
to
221
| if (data instanceof Offer) { | ||
| Offer offer = (Offer) data; | ||
| openOffer = openOfferManager.getOpenOfferById(offer.getId()).orElse(null); | ||
| } |
There was a problem hiding this comment.
I'd rather do this in the OfferBookViewModel
|
I'm still merging this PR although as Codacy has permission issues (again) |
ghost
mentioned this pull request
|
@xyzmaker123 thanks for working on this. Can you post a screenshot of what this looks like in the context of the whole offer book screen? |
|
@pazza83 Sure, two examples: |
|
@xyzmaker123 thanks looks good. Not sure where the 'add duplicate icon' will be included and #5774 (comment) Would it make sense to have 3 options:
cc: @ripcurlx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4986
Screenshots: