Fix NPE from BurningManView column comparators #6666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that none of the key extractor functions passed to 'Comparator.comparing(fn)' can return null, as this results in an NPE when the corresponding column is sorted in the UI, but has blank entries (such as the BTC received for a BSQ burn in the balance entries table). (Make blanks appear smallest in magnitude using 'Comparator.nullsFirst' or by defaulting to 0 instead of null, since the entries are initially sorted biggest to smallest, pushing them to the bottom of the table.) Also change the default sort type of the burned BSQ column, which should be ASCENDING since the entries are negative.
Replace uses of 'Comparator.comparing' with 'comparing[Double|Int|Long]' in BurningManView, as appropriate, since it is slightly more efficient.
1) Replace statement lambda with expression lambda; 2) Use '.iterator().next()' instead of 'new ArrayList<>(_).get(0)'.
ripcurlx
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent an NPE when a user attempts to sort a column (excluding Revenue) containing blank entries in the Revenue table of a selected contributor in the DAO / Proof of Burn / BurningMen view. Such blank entries appear when viewing individual balance items instead of by month, such as the received BTC of a burned BSQ entry, or the burned BSQ of received BTC entry.
Prior to this change, errors such as the following occur:
(Line numbers in BurningManView may be slightly off.)