Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GetBlocksRequestHandler's reply list once #6995

Conversation

alvasw
Copy link
Contributor

@alvasw alvasw commented Jan 6, 2024

Previously, the onGetBlocksRequest method created an ArrayList and two LinkedList before creating the GetBlocksResponse. The first two lists were never used. PR #6947 introduced the second LinkedList creation. With this change, the GetBlocksRequestHandler only creates a single LinkedList.

Previously, the onGetBlocksRequest method created an ArrayList and two
LinkedList before creating the GetBlocksResponse. The first two lists
were never used. PR bisq-network#6947 introduced the second LinkedList creation.
With this change, the GetBlocksRequestHandler only creates a single
LinkedList.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 566ab53 into bisq-network:master Jan 8, 2024
3 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.15 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants