Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] Apply exclude for hash annotation to filter #7152

Conversation

HenrikJannsen
Copy link
Collaborator

Based on #7151

By that the newly added fields will not alter the byte array used for the hash and the signature, thus it will not cause issues with removing an old filter which did not inculde those new fields.

Signed-off-by: HenrikJannsen <[email protected]>
Signed-off-by: HenrikJannsen <[email protected]>
@HenrikJannsen HenrikJannsen force-pushed the apply-ExcludeForHash-annotation-to-filter branch from 09b034d to b3288e3 Compare June 8, 2024 08:02
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.16 milestone Jun 8, 2024
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HenrikJannsen HenrikJannsen dismissed alejandrogarcia83’s stale review June 8, 2024 21:36

The merge-base changed after approval.

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit ed4bfe6 into bisq-network:master Jun 8, 2024
6 checks passed
@HenrikJannsen HenrikJannsen deleted the apply-ExcludeForHash-annotation-to-filter branch June 13, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants