Reduce bundled javacv library size #7166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of the javacv library when re-adding the QR code scanner feature for mobile notification pairing in bisq-network#7050, the Bisq binary increased to nearly 1 GB from its previous size of around 300 MB. When including the javacv-platform dependency, it pulls in binaries for all platforms. But it is possible to limit this by utilizing the gradle-javacpp platform plugin which by default will pull in binaries only for the current platform. Reference: https:/bytedeco/gradle-javacpp#the-platform-plugin With this change, the included libs went from ~980 MB down to ~366 MB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the javacv library when re-adding the QR code scanner feature for mobile notification pairing in #7050, the Bisq binary increased to nearly 1 GB from its previous size of around 300 MB.
When including the javacv-platform dependency, it pulls in binaries for all platforms. But it is possible to limit this by utilizing the gradle-javacpp platform plugin which by default will pull in binaries only for the current platform.
Reference: https:/bytedeco/gradle-javacpp#the-platform-plugin
With this change, the included libs went from ~980 MB down to ~366 MB.