Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 33 #1016

Closed
ripcurlx opened this issue Feb 23, 2022 · 7 comments
Closed

For Cycle 33 #1016

ripcurlx opened this issue Feb 23, 2022 · 7 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@ripcurlx
Copy link
Contributor

ripcurlx commented Feb 23, 2022

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 2743
  • USD requested: 3429
  • BSQ rate: 1.25 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 32 #984

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Bisq Desktop Maintainer dev* 2160 bisq-network/roles#63 (comment)
Bitcoin Fullnode Operator ops* 50 bisq-network/roles#67 (comment)
GitHub Admin ops* 25 bisq-network/roles#16 (comment)
Release preparations dev* 276 v1.8.2
PR Review #5963 dev 150 bisq-network/bisq#5963
PR Review #5976 dev 270 bisq-network/bisq#5976
PR Review #5983 dev 30 bisq-network/bisq#5983
PR Review #5984 dev 10 bisq-network/bisq#5984
PR Review #5985 dev 240 bisq-network/bisq#5985 This was not just a review, but quite a lot of code changes from my side as well: https:/bisq-network/bisq/pull/5985/commits
PR Review #5991 dev 80 bisq-network/bisq#5991
PR Review #6001 dev 48 bisq-network/bisq#6001
PR Review #6002 dev 22 bisq-network/bisq#6002
PR Review #6005 dev 4 bisq-network/bisq#6005
PR Review #6014 dev 64 bisq-network/bisq#6014
Improve text and icon colors for disabled offers dev 0 bisq-network/bisq#6017

I'm not putting up my team lead efforts up for compensation (~5% of my time).

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional (the linter ignores it), and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

I'm currently working on API examples in my private repository until it is in a portable state: https:/ripcurlx/bisq-api-examples/

I'll rest on getting monitor.bisq.network into a working state again to focus on the API release and Bisq2.

@ripcurlx ripcurlx changed the title [WIP] For Cycle 33 For Cycle 33 Feb 23, 2022
@ghost ghost added the parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid label Feb 23, 2022
@ghost
Copy link

ghost commented Feb 23, 2022

Info

Read BSQ amount from summary: 2743
Read USD amount from summary: 3429
Read BSQ rate from summary: 1.25
Parsed lineitem: {"team":"dev","amount":2160}
Parsed lineitem: {"team":"ops","amount":50}
Parsed lineitem: {"team":"ops","amount":25}
Parsed lineitem: {"team":"dev","amount":276}
Parsed lineitem: {"team":"dev","amount":150}
Parsed lineitem: {"team":"dev","amount":270}
Parsed lineitem: {"team":"dev","amount":30}
Parsed lineitem: {"team":"dev","amount":10}
Parsed lineitem: {"team":"dev","amount":240}
Parsed lineitem: {"team":"dev","amount":80}
Parsed lineitem: {"team":"dev","amount":48}
Parsed lineitem: {"team":"dev","amount":22}
Parsed lineitem: {"team":"dev","amount":4}
Parsed lineitem: {"team":"dev","amount":64}

Errors

Unknown team specified: ---
Invalid amount specified: ---:
Tableformat: request lineitem #1 did not pass validation.

@ghost ghost added team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Feb 23, 2022
@MwithM MwithM added this to the Cycle 33 milestone Feb 23, 2022
@ghost ghost added parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Feb 23, 2022
@ghost
Copy link

ghost commented Feb 23, 2022

Info

Read BSQ amount from summary: 2743
Read USD amount from summary: 3429
Read BSQ rate from summary: 1.25
Parsed lineitem: {"team":"dev","amount":2160}
Parsed lineitem: {"team":"ops","amount":50}
Parsed lineitem: {"team":"ops","amount":25}
Parsed lineitem: {"team":"dev","amount":276}
Parsed lineitem: {"team":"dev","amount":150}
Parsed lineitem: {"team":"dev","amount":270}
Parsed lineitem: {"team":"dev","amount":30}
Parsed lineitem: {"team":"dev","amount":10}
Parsed lineitem: {"team":"dev","amount":240}
Parsed lineitem: {"team":"dev","amount":80}
Parsed lineitem: {"team":"dev","amount":48}
Parsed lineitem: {"team":"dev","amount":22}
Parsed lineitem: {"team":"dev","amount":4}
Parsed lineitem: {"team":"dev","amount":64}

Errors

Unknown team specified: ---
Invalid amount specified: ---:
Tableformat: request lineitem #1 did not pass validation.

@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid and removed parsed:invalid https://bisq.wiki/Compensation#Ensure_your_request_is_valid labels Feb 23, 2022
@ripcurlx
Copy link
Contributor Author

@sqrrm Could you please approve my CR? Thanks!

@ripcurlx
Copy link
Contributor Author

To be on the save side timing wise, I've already submitted it to the DAO. TXID: 49baf3b3d82151a1521b6c817b8b690bc740b15e748c8070045192c7828d727b

@Emzy
Copy link

Emzy commented Feb 25, 2022

As ops team lead I approve this compensation request for ops.

@ghost
Copy link

ghost commented Mar 7, 2022

Issuance by Team:

team amount BSQ amount USD
dev 2683.00 3354.00
ops 60.00 75.00

Total Issuance: 2743.00 BSQ (equivalent to: 3429.00 USD)

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Mar 7, 2022
@MwithM
Copy link
Contributor

MwithM commented Mar 7, 2022

Closed as accepted.

@MwithM MwithM closed this as completed Mar 7, 2022
@ripcurlx ripcurlx mentioned this issue Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team team:ops https://bisq.wiki/Ops_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

4 participants