Clean up temp plugin installation folder (#936)

* Clean up temp plugin installation folder * Use defer
bitrise-io · Apr 10, 2024 · ddae9dd · ddae9dd
1 parent 52199a8
commit ddae9dd
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/plugins/install.go b/plugins/install.go
@@ -146,9 +146,9 @@ func installLocalPlugin(pluginSourceURI, pluginLocalPth string) (Plugin, error)
  }
 
  if installedPluginVersionPtr != nil {
- log.Warnf("installed plugin found with version (%s), overriding it...", (*installedPluginVersionPtr).String())
+ log.Warnf("installed plugin found with version %s, upgrading...", (*installedPluginVersionPtr).String())
  } else {
- log.Warnf("installed local plugin found, overriding it...")
+ log.Warnf("installed local plugin found, upgrading...")
  }
  }
  // ---
@@ -157,6 +157,12 @@ func installLocalPlugin(pluginSourceURI, pluginLocalPth string) (Plugin, error)
  if err != nil {
  return Plugin{}, fmt.Errorf("failed to create tmp plugin dir, error: %s", err)
  }
+ defer func() {
+ err = os.RemoveAll(tmpPluginDir)
+ if err != nil {
+ log.Warnf("Failed to clean up temp dir after plugin installation, error: %s", err)
+ }
+ }()
 
  // Install plugin executable
  executableURL := newPlugin.ExecutableURL()