Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused BITRISE_TMP_DIR #890

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Clean up unused BITRISE_TMP_DIR #890

merged 2 commits into from
Mar 4, 2024

Conversation

ofalvai
Copy link
Contributor

@ofalvai ofalvai commented Oct 27, 2023

Checklist

Version

Requires a MAJOR/MINOR/PATCH version update

Context

Looks like nothing really uses this special dir anymore:

Changes

Investigation details

Decisions

@lpusok
Copy link
Contributor

lpusok commented Oct 27, 2023

Found a comment that hints at BITRISE_TMP_DIR having bettter performance then system tmp dir, can this be true? https:/bitrise-io/cachecontrol/issues/3#issue-413472711

@ofalvai
Copy link
Contributor Author

ofalvai commented Oct 27, 2023

I don't think it applies anymore, I guess that was in the context of Docker volumes. But in the current container setup /tmp is not a mounted volume, so there should be no impact. And even if there is, I couldn't find any step or other tool that uses this directory today.

lpusok
lpusok previously approved these changes Nov 22, 2023
@ofalvai ofalvai merged commit dd562e2 into master Mar 4, 2024
5 checks passed
@ofalvai ofalvai deleted the ofalvai/bitrise_tmp_dir branch March 4, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants