Tool version reporting #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
ofalvai
force-pushed
the
BE-1221-tool-version-telemetry
branch
from
0d761fb
to
0c03dd7
Compare
ofalvai
force-pushed
the
BE-1221-tool-version-telemetry
branch
from
0c03dd7
to
abb8e46
Compare
pgyula
approved these changes
Jan 2, 2024
| } | ||
|
|
||
| func (r *ASDFVersionReporter) CurrentToolVersions() (map[string]ToolVersion, error) { | ||
| cmd := r.cmdFactory.Create("asdf", []string{"current"}, &command.Opts{}) |
There was a problem hiding this comment.
what happens to default tools (e.g. Flutter) that aren't set by asdf but available in our stack? Do we capture them ?
There was a problem hiding this comment.
Not yet, but we are constantly trying to move more and more tools under ASDF (or any other version manager in the future).
But @godrei had a good analysis of Flutter versions recently that you might find interesting: https://bitrise.atlassian.net/wiki/spaces/ENGI/pages/2734293197/RFC+Flutter+SDK+version+on+stacks
ofalvai
force-pushed
the
BE-1221-tool-version-telemetry
branch
from
abb8e46
to
9800c02
Compare
ofalvai
added a commit
that referenced
this pull request
Jan 8, 2024
<!-- Thanks for contributing to the Bitrise CLI! Please fill this template with the details of your change. --> ### Checklist <!-- Put an `x` in the boxes that apply. You can also fill these out after creating the PR. This is simply a reminder of what we are going to look for before merging your code. --> - [ ] I've read and followed the [Contribution Guidelines](https:/bitrise-io/bitrise/blob/master/.github/CONTRIBUTING.md) - [ ] `README.md` is updated with the changes (if needed) ### Version <!-- Leave this untouched if you don't know, we'll help --> Requires a *MAJOR/MINOR/PATCH* [version update](https://semver.org/) ### Context Follow up to #902 ### Changes - Send the collected tool version report as a standard telemetry event. - Add a few more useful properties to the event ### Investigation details <!-- Please share any alternative solutions that were considered along with investigation details. --> ### Decisions As the tool version map contains arbitrary key-value pairs and we'll add more tools under ASDF, I decided to just serialize everything as JSON. We can process the JSON at query-time easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
Telemetry for how tool version managers are used, what are the active versions during the build, etc.
Changes
Investigation details
Decisions