Fix per-step test result dir handling #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
commented
Mar 15, 2024
| @@ -836,16 +836,25 @@ func (r WorkflowRunner) activateAndRunSteps( | |||
| "BITRISE_STEP_SOURCE_DIR": stepDir, | |||
| }) | |||
|
|
|||
| // ensure a new testDirPath and if created successfuly then attach it to the step process by and env | |||
| testDirPath, err := ioutil.TempDir(os.Getenv(configs.BitriseTestDeployDirEnvKey), "test_result") | |||
There was a problem hiding this comment.
ioutil.TempDir() is deprecated and calls os.Mkdir() directly since Go 1.17
tothszabi
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
When running in agent mode with a configured cleanup, this error happens:
This is caused by not making sure that the parent dir exists before calling
os.MkdirTemp()on it: https://cs.opensource.google/go/go/+/refs/tags/go1.22.0:src/os/tempfile.go;l=108Changes
Investigation details
Decisions