Move steplib step activator from CLI to stepman #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
godrei
reviewed
Jul 1, 2024
| stepInfo, didUpdate, err := activateStepLibStep(stepIDData, stepDir, stepYMLPth, isStepLibUpdated, isSteplibOfflineMode) | ||
| didStepLibUpdate = didUpdate | ||
|
|
||
| stepInfoPtr.ID = stepInfo.ID |
There was a problem hiding this comment.
Is the stepInfoPtr update happening within activator.ActivateSteplibRefStep?
There was a problem hiding this comment.
cli/step_activator.go
Outdated
| if err != nil { | ||
| return "", "", didStepLibUpdate, err | ||
| return "", "", didStepLibUpdate, fmt.Errorf("activate steplib step reference: %w", err) |
There was a problem hiding this comment.
Do we need reference at the end of the error message? I think we activate the StepLib step rather than its reference.
godrei
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
README.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
#973
Changes
Investigation details
Decisions