Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Optimizer and integrations #1125

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

stevhliu
Copy link
Contributor

@stevhliu stevhliu commented Mar 12, 2024

This PR cleans up the optimizer section by separating the actionable and practical code examples from the more conceptual explanations of how 8-bit optimizers work. I also added very brief code examples in the Integration section to better show how they work for each HF library. Other more minor things include:

➖ remove duplicate Quantization doc from the API section
➕ new explanation doc for how 8-bit optimizers work

cc @Titus-von-Koeller

Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

docs/source/explanations/optimizers.mdx Outdated Show resolved Hide resolved
docs/source/explanations/optimizers.mdx Outdated Show resolved Hide resolved
docs/source/explanations/optimizers.mdx Outdated Show resolved Hide resolved
docs/source/index.mdx Outdated Show resolved Hide resolved
docs/source/index.mdx Outdated Show resolved Hide resolved
docs/source/integrations.mdx Outdated Show resolved Hide resolved
docs/source/integrations.mdx Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the refactor you did in this section. Everything flows much better, is coherent and I like the new additions, cleaned up code examples and clarifications a lot! Great work, thanks :D I wish I had these docs when I got started with BNB at the time 😅


[[autodoc]] bitsandbytes.nn.StableEmbedding
- __init__
For more conceptual details and explanation about 8-bit optimizers, take a look at the [8-bit optimizers](./explanations/optimizers) guide.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the new structure, much more graspable and gradual disclosure of details is dosed just right. Excellent!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rework, 0 complaints!

@Titus-von-Koeller Titus-von-Koeller merged commit 0548376 into bitsandbytes-foundation:main Mar 15, 2024
2 checks passed
@stevhliu stevhliu deleted the cleanup branch March 15, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants