Fix: preserve datetime precision after Timex.shift/2 #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Resolves #731
Unfortunately this broke with elixir-lang/elixir@5a583c7 which was released with Elixir 1.14.3
As
Timex.shift/2
calculates the total microseconds of the shift options and then usesDateTime.add/4
to apply, Elixir returns a new datetime with the highest precision it finds (microseconds) opposed to keeping the original precision.Elixir 1.13.4:
Elixir 1.14.4: