Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-1549] Select specific characters from password via CLI #5042

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jj-style
Copy link

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add ability to select specific characters from the password by their indices via the cli.
E.g. when prompted by pages to select the 3rd 15th and 17th character of the password you can do:

bw get password --characters "3,15,17" myBank
# 3: p
# 15: w
# 17: d

Code changes

  • apps/cli/src/vault.program.ts Update command line options to get on CLI to accept characters which is a list of comma-selected indices of characters to print from the password.
  • apps/cli/src/commands/get.command.ts if characters supplied in above command then used to filter specific characters from the password before returning

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2023

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-1549

@bitwarden-bot bitwarden-bot changed the title Select specific characters from password via CLI [PM-1549] Select specific characters from password via CLI Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants