Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13213] Replace ${{ github.ref }} with GITHUB_REF in build.yml scripts #4857

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

AJGranowski
Copy link
Contributor

@AJGranowski AJGranowski commented Oct 5, 2024

🎟️ Tracking

N/a

📔 Objective

A simple defensive programming change. Data should be separated from code where possible to avoid command/code injection (CWE-78).

This is not an exploitable vulnerability as far as I can tell, so this change is just a precautionary defensive measure.

📸 Screenshots

N/a

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@AJGranowski AJGranowski requested a review from a team as a code owner October 5, 2024 23:33
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-13213

@bitwarden-bot bitwarden-bot changed the title Replace ${{ github.ref }} with GITHUB_REF in build.yml scripts [PM-13213] Replace ${{ github.ref }} with GITHUB_REF in build.yml scripts Oct 5, 2024
@vgrassia vgrassia merged commit 1fb366d into bitwarden:main Oct 17, 2024
31 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants