-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BRE-344 - Create Repository Management workflow #4863
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4863 +/- ##
==========================================
+ Coverage 41.57% 41.67% +0.10%
==========================================
Files 1357 1361 +4
Lines 64056 63901 -155
Branches 5891 5862 -29
==========================================
+ Hits 26631 26633 +2
+ Misses 36208 36061 -147
+ Partials 1217 1207 -10 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick seagulling.
@@ -0,0 +1,250 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ We don't have to have these at the tops of workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need them, but I believe it was decided a long time ago to keep them. We can revisit that and make a card to update all the workflows across the organization to remove the document start marker, and then update the linter to make sure they don't exist at the top of the workflow files. From an initial search from the repos I have locallly cloned, it will be at least 209 workflow files across 30 repositories.
I do think we should settle on a standard and enforce it across all workflow files using the linter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at it, and it's easy to make sure the linter catches document start and document end markers. I made a card and will put in a PR.
@@ -0,0 +1,250 @@ | |||
--- | |||
name: Repository Management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛏️ I try to not treat most of these names and descriptions as Titles but statements with just one leading capitalization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and update the name and then make a card for updating the linter with a rule for that.
🎟️ Tracking
📔 Objective
This PR removes the old
Version Bump
workflow and creates a newRepository Management
workflow that is used for version bumps and cutting rc/hotfix-rc branches.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes