Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRE-344 - Create Repository Management workflow #4863

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

vgrassia
Copy link
Member

@vgrassia vgrassia commented Oct 7, 2024

🎟️ Tracking

📔 Objective

This PR removes the old Version Bump workflow and creates a new Repository Management workflow that is used for version bumps and cutting rc/hotfix-rc branches.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vgrassia vgrassia self-assigned this Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.67%. Comparing base (452a45b) to head (18338e6).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4863      +/-   ##
==========================================
+ Coverage   41.57%   41.67%   +0.10%     
==========================================
  Files        1357     1361       +4     
  Lines       64056    63901     -155     
  Branches     5891     5862      -29     
==========================================
+ Hits        26631    26633       +2     
+ Misses      36208    36061     -147     
+ Partials     1217     1207      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Logo
Checkmarx One – Scan Summary & Detailsafb1e108-1865-4af9-8fd5-72b44613e39a

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Privacy_Violation /src/Core/Models/Data/UserWithCalculatedPremium.cs: 19 Attack Vector
MEDIUM Privacy_Violation /src/Core/Models/Data/UserWithCalculatedPremium.cs: 26 Attack Vector
MEDIUM Privacy_Violation /src/Core/Models/Data/UserWithCalculatedPremium.cs: 18 Attack Vector
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 104 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 60 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 111 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /build.yml: 598 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Unpinned Actions Full Length Commit SHA /repository-management.yml: 119 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Auth/Controllers/TwoFactorController.cs: 112
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 220
LOW Unpinned Actions Full Length Commit SHA /build.yml: 631
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 129
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 137
LOW Unpinned Actions Full Length Commit SHA /version-bump.yml: 122
LOW Unpinned Actions Full Length Commit SHA /build.yml: 582

@vgrassia vgrassia marked this pull request as ready for review October 14, 2024 21:16
@vgrassia vgrassia requested a review from a team as a code owner October 14, 2024 21:16
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick seagulling.

@@ -0,0 +1,250 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ We don't have to have these at the tops of workflows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need them, but I believe it was decided a long time ago to keep them. We can revisit that and make a card to update all the workflows across the organization to remove the document start marker, and then update the linter to make sure they don't exist at the top of the workflow files. From an initial search from the repos I have locallly cloned, it will be at least 209 workflow files across 30 repositories.

I do think we should settle on a standard and enforce it across all workflow files using the linter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at it, and it's easy to make sure the linter catches document start and document end markers. I made a card and will put in a PR.

@@ -0,0 +1,250 @@
---
name: Repository Management
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️ I try to not treat most of these names and descriptions as Titles but statements with just one leading capitalization.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and update the name and then make a card for updating the linter with a rule for that.

@vgrassia vgrassia merged commit 7408f3e into main Oct 15, 2024
52 checks passed
@vgrassia vgrassia deleted the bre-344_update-version-bump-workflow branch October 15, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants