Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenLDAP Docker configuration #4902

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Remove OpenLDAP Docker configuration #4902

merged 1 commit into from
Oct 16, 2024

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Oct 16, 2024

๐ŸŽŸ๏ธ Tracking

N/A

๐Ÿ“” Objective

Remove the OpenLDAP Docker configuration, which has been moved to the Directory Connector repository. See bitwarden/directory-connector#637.

๐Ÿ“ธ Screenshots

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 41.67%. Comparing base (7408f3e) to head (94accd5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4902   +/-   ##
=======================================
  Coverage   41.67%   41.67%           
=======================================
  Files        1361     1361           
  Lines       63901    63901           
  Branches     5862     5862           
=======================================
  Hits        26633    26633           
  Misses      36061    36061           
  Partials     1207     1207           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ e0079a3e-b8ff-461d-8478-6298b4fc2f50

No New Or Fixed Issues Found

@eliykat eliykat merged commit 7a509d2 into main Oct 16, 2024
52 checks passed
@eliykat eliykat deleted the remove-openldap branch October 16, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants