Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13826] [deps]: Update MessagePack to 2.5.187 [SECURITY] #4910

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 17, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
MessagePack (source) 2.5.172 -> 2.5.187 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-48924

Impact

When this library is used to deserialize messagepack data from an untrusted source, there is a risk of a denial of service attack by an attacker that sends data contrived to produce hash collisions, leading to large CPU consumption disproportionate to the size of the data being deserialized.

This is similar to a prior advisory, which provided an inadequate fix for the hash collision part of the vulnerability.

Patches

The following steps are required to mitigate this risk.

  1. Upgrade to a version of the library where a fix is available.
  2. Review the steps in this previous advisory to ensure you have your application configured for untrusted data.

Workarounds

If upgrading MessagePack to a patched version is not an option for you, you may apply a manual workaround as follows:

  1. Declare a class that derives from MessagePackSecurity.
  2. Override the GetHashCollisionResistantEqualityComparer<T> method to provide a collision-resistant hash function of your own and avoid calling base.GetHashCollisionResistantEqualityComparer<T>().
  3. Configure a MessagePackSerializerOptions with an instance of your derived type by calling WithSecurity on an existing options object.
  4. Use your custom options object for all deserialization operations. This may be by setting the MessagePackSerializer.DefaultOptions static property, if you call methods that rely on this default property, and/or by passing in the options object explicitly to any Deserialize method.

References

For more information

If you have any questions or comments about this advisory:


Release Notes

MessagePack-CSharp/MessagePack-CSharp (MessagePack)

v2.5.187

Changes:

This list of changes was auto generated.


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

PM-13826

@renovate renovate bot requested a review from a team as a code owner October 17, 2024 20:47
@renovate renovate bot added the security label Oct 17, 2024
@renovate renovate bot requested review from ike-kottlowski and a team October 17, 2024 20:47
@withinfocus
Copy link
Contributor

This is removed in #4909.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.75%. Comparing base (1fb366d) to head (e18bc68).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4910   +/-   ##
=======================================
  Coverage   41.75%   41.75%           
=======================================
  Files        1363     1363           
  Lines       63915    63915           
  Branches     5853     5853           
=======================================
  Hits        26686    26686           
  Misses      36026    36026           
  Partials     1203     1203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot changed the title [deps]: Update MessagePack to 2.5.187 [SECURITY] [deps]: Update MessagePack to 2.5.187 [SECURITY] - autoclosed Oct 17, 2024
@renovate renovate bot closed this Oct 17, 2024
@renovate renovate bot deleted the renovate/nuget-messagepack-vulnerability branch October 17, 2024 21:31
@bitwarden-bot bitwarden-bot changed the title [deps]: Update MessagePack to 2.5.187 [SECURITY] - autoclosed [PM-13826] [deps]: Update MessagePack to 2.5.187 [SECURITY] Oct 18, 2024
@bitwarden-bot
Copy link

Internal tracking:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants