Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lemma model can select rule for wrong pos type #1

Open
bjascob opened this issue May 14, 2019 · 0 comments
Open

Lemma model can select rule for wrong pos type #1

bjascob opened this issue May 14, 2019 · 0 comments
Labels
hold No planned change at this time

Comments

@bjascob
Copy link
Owner

bjascob commented May 14, 2019

For the test case 'quilting/NOUN' and 'plastering/NOUN', the words are not in the lemma lookup so OOV rules are called.

getAllLemmasOOV('quilting`, 'NOUN')` returns 'quilt' (it selects rule "ing,,False")
getAllLemmasOOV('plastering`, 'NOUN') returns 'plastering' (it selects rule ",,False")

In the case of 'quilting' the model selects a verb rule. To prevent this consider...

  • Add hard-coded rules to choose the next best if the rule doesn't apply
  • Split the model into 3 parts (verb, noun, adj/adv) and run separately
  • Add contra-cases to training data so it learns not to do this

In addition, the model classes include the ending letters to remove. However, similar above, there is nothing to prevent it selecting a "remove ing" rule for a word ending in something else. I'm not aware of this causing issues but it should be investigated when looking into the first issue.

@bjascob bjascob added the hold No planned change at this time label Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold No planned change at this time
Projects
None yet
Development

No branches or pull requests

1 participant