-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use existing TaggedLogger instead of re-wrapping it with TaggedLogging
#488
Comments
@kriansa Yep, that sounds reasonable. Do you want to work up a pull request with tests? |
Sure, will send a patch shortly |
interesting, I just bumped activesupport from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
dotenv/lib/dotenv/rails.rb
Lines 91 to 96 in 6dd0385
This initializer wraps the existing Rails logger into
ActiveSupport::TaggedLogging
, which for the default Rails config is not bad, but when custom loggers are in place, it could be troublesome.I, for instance, currently have a custom logger that mimics
TaggedLogging
and supports its interface. I think we should just test if the existing Rails logger responds to.tagged
and then call it instead of re-wrapping it. Something like that (haven't tested yet):What do you think? By the way, awesome work on the new release! 👍
The text was updated successfully, but these errors were encountered: